From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 91E669E1F7 for ; Mon, 27 Nov 2023 10:52:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6E9B639AF for ; Mon, 27 Nov 2023 10:52:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 27 Nov 2023 10:52:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9670544A5E for ; Mon, 27 Nov 2023 10:52:07 +0100 (CET) Message-ID: <924f16d9-542a-4dfc-b374-db7ab7ad589b@proxmox.com> Date: Mon, 27 Nov 2023 10:52:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB-large To: Proxmox Backup Server development discussion , Dominik Csapak References: <20230801092954.1686860-1-d.csapak@proxmox.com> <20230801092954.1686860-2-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230801092954.1686860-2-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs, environment.rs] Subject: Re: [pbs-devel] [RFC PATCH proxmox-backup 1/3] api-types: make UploadStatistic an api type X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Nov 2023 09:52:08 -0000 On 01.08.23 11:29, Dominik Csapak wrote: > and move it to pbs_api_types. We'll want this to expose on the api. > > Signed-off-by: Dominik Csapak > --- > pbs-api-types/src/datastore.rs | 38 ++++++++++++++++++++++++++++++++++ > src/api2/backup/environment.rs | 35 +------------------------------ > 2 files changed, 39 insertions(+), 34 deletions(-) > > diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs > index 73c4890e..41db680c 100644 > --- a/pbs-api-types/src/datastore.rs > +++ b/pbs-api-types/src/datastore.rs > @@ -419,6 +419,44 @@ pub struct SnapshotVerifyState { > pub state: VerifyState, > } > > +#[api()] > +#[derive(Copy, Clone, Serialize, Deserialize)] misses: #[serde(rename_all = "kebab-case")] or does that break manifest? If, then mabye a simple clone/wrapper struct for the API would be nicer, so that those two use-cases get decoupled explicitly. > +/// Chunk upload statistics of a snapshot > +pub struct UploadStatistic { > + /// Amount of chunks uploaded (incl. duplicates) > + pub count: u64, > + /// Uncompressed bytes uploaded > + pub size: u64, > + /// Compressed bytes uploaded > + pub compressed_size: u64, > + /// Amount of duplicate chunks uploaded > + pub duplicates: u64, > +} > +