From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5C2DF653B5 for ; Tue, 3 Nov 2020 07:54:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 59D20288E9 for ; Tue, 3 Nov 2020 07:54:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id EA89E288DC for ; Tue, 3 Nov 2020 07:54:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B446C45FDA for ; Tue, 3 Nov 2020 07:54:57 +0100 (CET) To: Dietmar Maurer , Proxmox Backup Server development discussion References: <20201102113439.26618-1-d.csapak@proxmox.com> <20201102113439.26618-5-d.csapak@proxmox.com> <737595678.644.1604382332515@webmail.proxmox.com> From: Dominik Csapak Message-ID: <923acd34-1119-8bd2-3106-2830955aadf4@proxmox.com> Date: Tue, 3 Nov 2020 07:54:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <737595678.644.1604382332515@webmail.proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.415 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 4/5] api2/admin/datastore: start the garbage_collection task with our helper X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2020 06:54:58 -0000 On 11/3/20 6:45 AM, Dietmar Maurer wrote: >> instead of manually, this has the advantage that we now set >> the jobstate correctly and can return with an error if it is >> currently running (instead of failing in the task) > > We always send notifications now, even for manually triggered task. > > So the behavior is finally inconsistent, i.e. we do not send notifications for > manually triggered verify. Maybe we should change that too? > ok well that was not really my intention, so we could simply add an option to do_garbage_collection_job ? or as you said add them to manual verify too, im ok with both..