From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 7D20084C80
 for <pbs-devel@lists.proxmox.com>; Wed, 15 Dec 2021 16:00:16 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 6E5F51443C
 for <pbs-devel@lists.proxmox.com>; Wed, 15 Dec 2021 15:59:46 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id E766A1442E
 for <pbs-devel@lists.proxmox.com>; Wed, 15 Dec 2021 15:59:45 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BB84A402E8
 for <pbs-devel@lists.proxmox.com>; Wed, 15 Dec 2021 15:59:45 +0100 (CET)
Message-ID: <91872059-0df5-e491-33e3-ca25b0cccfd6@proxmox.com>
Date: Wed, 15 Dec 2021 15:59:45 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101
 Thunderbird/96.0
Content-Language: en-US
To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com>
References: <20211103073651.170428-1-d.csapak@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20211103073651.170428-1-d.csapak@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.554 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.962 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2] api: zfs: create zpool
 with relatime=on
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 15 Dec 2021 15:00:16 -0000

On 03.11.21 08:36, Dominik Csapak wrote:
> some operations (e.g. garbage collection/restore/etc.) are very read
> intensive on the chunks, and having atime=on and relatime=off (zfs default)
> makes those write intensive operations too. Additionally, 'ext4' defaults to
> relatime, so also change the default for api-created zpools.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * do not disable atime, it must be on for relatime to work, quote
> from 'man zfsprops' for 'relatime':
> 
> Controls the manner in which the access time is updated when atime=on is set.
> 
>  src/api2/node/disks/zfs.rs | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/src/api2/node/disks/zfs.rs b/src/api2/node/disks/zfs.rs
> index 9c3a0958..56dedab5 100644
> --- a/src/api2/node/disks/zfs.rs
> +++ b/src/api2/node/disks/zfs.rs
> @@ -273,13 +273,15 @@ pub fn create_zpool(
>                  proxmox_systemd::enable_unit(&import_unit)?;
>              }
>  
> +            let mut command = std::process::Command::new("zfs");
> +            command.arg("set");
>              if let Some(compression) = compression {
> -                let mut command = std::process::Command::new("zfs");
> -                command.args(&["set", &format!("compression={}", compression), &name]);
> -                task_log!(worker, "# {:?}", command);
> -                let output = pbs_tools::run_command(command, None)?;
> -                task_log!(worker, "{}", output);
> +                command.arg(&format!("compression={}", compression));
>              }
> +            command.args(&["relatime=on", &name]);
> +            task_log!(worker, "# {:?}", command);
> +            let output = pbs_tools::run_command(command, None)?;
> +            task_log!(worker, "{}", output);
>  
>              if add_datastore {
>                  let lock = pbs_config::datastore::lock_config()?;

looks good to me but would need a rebase on current master branch.