From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2E78C693AF for ; Mon, 13 Sep 2021 11:36:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 208A92842B for ; Mon, 13 Sep 2021 11:36:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id AF4F728420 for ; Mon, 13 Sep 2021 11:36:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7A974447A2 for ; Mon, 13 Sep 2021 11:36:31 +0200 (CEST) To: Proxmox Backup Server development discussion , Dominik Csapak References: <20210909134819.2082605-1-d.csapak@proxmox.com> From: Hannes Laimer Message-ID: <9128b335-2f1b-5390-57c4-72f36051d8b9@proxmox.com> Date: Mon, 13 Sep 2021 11:36:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210909134819.2082605-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.788 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.584 Looks like a legit reply (A) POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox/proxmox-backup] add 'pbs-shell' tool X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Sep 2021 09:36:35 -0000 I just noticed two things while testing: - if an endpoint expects a parameter called 'path'(e.g. POST /config /datastore), the parameter conflicts with the api path itself - even though commands like verify(POST /admin/datastore//verify) or gc(POST /admin/datastore//gc) are started and run successfully, `Error: control socket connect failed - Connection refused (os error 111)` is displayed almost always at the end. Note: For testing I applied the patches on b65dfff574f44e5a60db3903d2226f4dbe386b7a, I assume the moving of stuff after that should not effect the functionality Am 09.09.21 um 15:48 schrieb Dominik Csapak: > this series adds the tool 'pbs-shell', similar to 'pvesh' and 'pmgsh' > this tool is intended mainly for debugging, but can be useful for > api calls not exposed via the client/manager. > > proxmox (and the dependency in proxmox-backup) need to be bumped > > proxmox-backup patches 2-5 are not strictly necessary, but improve > the api so that the 'ls' command works better > (there are still some api paths to be fixed) > > proxmox: > > Dominik Csapak (1): > proxmox: generate_usage_str: don't require static lifetimes > > proxmox/src/api/cli/format.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > proxmox-backup: > > Dominik Csapak (5): > add 'pbs-shell' utility > api2: add missing token list match_all property > api2: disks/directory: refactor BASE_MOUNT_DIR > api2: disks/directory: add 'name' property to directory mount listing > api2: nodes: add missing node list api call > > Makefile | 2 + > debian/pbs-shell.bc | 3 + > debian/proxmox-backup-server.bash-completion | 1 + > debian/proxmox-backup-server.install | 3 + > docs/Makefile | 8 + > docs/pbs-shell/description.rst | 3 + > docs/pbs-shell/man1.rst | 40 ++ > src/api2/access/user.rs | 35 +- > src/api2/mod.rs | 4 +- > src/api2/node/disks/directory.rs | 15 +- > src/api2/node/mod.rs | 12 +- > src/bin/pbs-shell.rs | 502 +++++++++++++++++++ > zsh-completions/_pbs-shell | 13 + > 13 files changed, 628 insertions(+), 13 deletions(-) > create mode 100644 debian/pbs-shell.bc > create mode 100644 docs/pbs-shell/description.rst > create mode 100644 docs/pbs-shell/man1.rst > create mode 100644 src/bin/pbs-shell.rs > create mode 100644 zsh-completions/_pbs-shell >