From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 60F67690A7
 for <pbs-devel@lists.proxmox.com>; Wed, 10 Mar 2021 12:47:32 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 576931C59F
 for <pbs-devel@lists.proxmox.com>; Wed, 10 Mar 2021 12:47:32 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 70A241C592
 for <pbs-devel@lists.proxmox.com>; Wed, 10 Mar 2021 12:47:31 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 380A9458EB
 for <pbs-devel@lists.proxmox.com>; Wed, 10 Mar 2021 12:47:31 +0100 (CET)
Message-ID: <91149079-342d-97dc-b557-2ea7f95e440f@proxmox.com>
Date: Wed, 10 Mar 2021 12:47:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:87.0) Gecko/20100101
 Thunderbird/87.0
Content-Language: en-US
To: Dominik Csapak <d.csapak@proxmox.com>,
 Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
References: <20210310091047.16557-1-d.csapak@proxmox.com>
 <20210310091047.16557-2-d.csapak@proxmox.com>
 <2ddefdf1-b6e8-9c23-caef-aa7de1c58005@proxmox.com>
 <491dc073-0b9f-8849-051e-156c6c38c05f@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <491dc073-0b9f-8849-051e-156c6c38c05f@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.549 Adjusted score from AWL reputation of From: address
 CTE_8BIT_MISMATCH       0.999 Header says 7bits but body disagrees
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [data.store, sencha.com]
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape: increase
 tapestore interval
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 10 Mar 2021 11:47:32 -0000

On 10.03.21 12:38, Dominik Csapak wrote:
> 
> 
> On 3/10/21 12:19 PM, Thomas Lamprecht wrote:
>> On 10.03.21 10:10, Dominik Csapak wrote:
>>> from 2 to 60 seconds. To retain the response time of the gui
>>> when adding/editing/removing, trigger a manual reload on these actions
>>>
>>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>>
>> Please add my Suggested-by or Reported-by tags for reference the next time,
>> thanks!
>>
> 
> yes of course, sorry

Thanks!

btw. can you please freshen up my brain on the storeid config from UpdateStore?
As its not used there directly and it's base class Ext.data.Store only knows
about storeId [0] (note the casing difference), and using that one would actually
register the store to the Ext.data.StoreManager [1] and we could avoid the detour
over querying the nav tree but do a 

Ext.data.StoreManager.lookup('pbs-tape-drive-list').load();

instead. Not sure about any extra cost of that manager, but code wise it would
be quite less (and only called from places where we know that PBS.enableTapeUI
is true already).

And if the UpdateStores `storeid` property is only a "copy-is-my-hobby" left
over, or really misspelled then I'd maybe drop it or fix spelling, respectively.

[0]: https://docs.sencha.com/extjs/6.0.1/classic/Ext.data.Store.html#cfg-storeId
[1]: https://docs.sencha.com/extjs/6.0.1/classic/Ext.data.StoreManager.html

> 
>>> ---
>>>   www/NavigationTree.js     | 11 ++++++++++-
>>>   www/tape/ChangerConfig.js |  6 ++++++
>>>   www/tape/DriveConfig.js   |  6 ++++++
>>>   3 files changed, 22 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/www/NavigationTree.js b/www/NavigationTree.js
>>> index 4bdfbc66..6d288f09 100644
>>> --- a/www/NavigationTree.js
>>> +++ b/www/NavigationTree.js
>>> @@ -122,7 +122,7 @@ Ext.define('PBS.view.main.NavigationTree', {
>>>           if (view.tapestore === undefined) {
>>>               view.tapestore = Ext.create('Proxmox.data.UpdateStore', {
>>>               autoStart: true,
>>> -            interval: 2 * 1000,
>>> +            interval: 60 * 1000,
>>>               storeid: 'pbs-tape-drive-list',
>>>               model: 'pbs-tape-drive-list',
>>>               });
>>> @@ -269,6 +269,15 @@ Ext.define('PBS.view.main.NavigationTree', {
>>>       },
>>>       },
>>>   +    reloadTapeStore: function() {
>>> +    let me = this;
>>> +    if (!PBS.enableTapeUI) {
>>> +        return;
>>> +    }
>>> +
>>> +    me.tapestore.load();
>>> +    },
>>> +
>>>       select: function(path, silent) {
>>>       var me = this;
>>>       if (me.rstore.isLoaded() && (!PBS.enableTapeUI || me.tapestore.isLoaded())) {
>>> diff --git a/www/tape/ChangerConfig.js b/www/tape/ChangerConfig.js
>>> index 1646ddef..1c048b23 100644
>>> --- a/www/tape/ChangerConfig.js
>>> +++ b/www/tape/ChangerConfig.js
>>> @@ -11,6 +11,11 @@ Ext.define('PBS.TapeManagement.ChangerPanel', {
>>>       controller: {
>>>       xclass: 'Ext.app.ViewController',
>>>   +    reloadTapeStore: function() {
>>> +        let navtree = Ext.ComponentQuery.query('navigationtree')[0];
>>> +        navtree.reloadTapeStore();
>>> +    },
>>> +
>>>       onAdd: function() {
>>>           let me = this;
>>>           Ext.create('PBS.TapeManagement.ChangerEditWindow', {
>>> @@ -40,6 +45,7 @@ Ext.define('PBS.TapeManagement.ChangerPanel', {
>>>         reload: function() {
>>>           this.getView().getStore().rstore.load();
>>> +        this.reloadTapeStore();
>>>       },
>>>         stopStore: function() {
>>> diff --git a/www/tape/DriveConfig.js b/www/tape/DriveConfig.js
>>> index 763f8e55..40d4b2a9 100644
>>> --- a/www/tape/DriveConfig.js
>>> +++ b/www/tape/DriveConfig.js
>>> @@ -19,6 +19,11 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
>>>       controller: {
>>>       xclass: 'Ext.app.ViewController',
>>>   +    reloadTapeStore: function() {
>>> +        let navtree = Ext.ComponentQuery.query('navigationtree')[0];
>>> +        navtree.reloadTapeStore();
>>> +    },
>>> +
>>>       onAdd: function() {
>>>           let me = this;
>>>           Ext.create('PBS.TapeManagement.DriveEditWindow', {
>>> @@ -57,6 +62,7 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
>>>         reload: function() {
>>>           this.getView().getStore().rstore.load();
>>> +        this.reloadTapeStore();
>>>       },
>>>         stopStore: function() {
>>>
>>