From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EB02879DC5 for ; Thu, 6 May 2021 08:24:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DBB131BAA0 for ; Thu, 6 May 2021 08:24:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D912E1BA92 for ; Thu, 6 May 2021 08:24:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A6B9A42965 for ; Thu, 6 May 2021 08:24:48 +0200 (CEST) Date: Thu, 6 May 2021 08:24:34 +0200 (CEST) From: Dietmar Maurer To: Proxmox Backup Server development discussion , Oguz Bektas Message-ID: <908022960.193.1620282274258@webmail.proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.5-Rev10 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.244 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs, proxmox.com, proxmox-backup-api.rs] Subject: Re: [pbs-devel] [PATCH backup] tape: create drive-state and changer-state directories with correct permissions X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 May 2021 06:24:50 -0000 Or just create the rundir at daemon startup? diff --git a/src/bin/proxmox-backup-api.rs b/src/bin/proxmox-backup-api.rs index e514a801..f50a04a5 100644 --- a/src/bin/proxmox-backup-api.rs +++ b/src/bin/proxmox-backup-api.rs @@ -39,6 +39,8 @@ async fn run() -> Result<(), Error> { config::update_self_signed_cert(false)?; + proxmox_backup::tools::create_run_dir()?; + proxmox_backup::rrd::create_rrdb_dir()?; proxmox_backup::server::jobstate::create_jobstate_dir()?; proxmox_backup::tape::create_tape_status_dir()?; > On 05/04/2021 3:10 PM Oguz Bektas wrote: > > > we need to also pass the intermediate_opts to avoid creating > /run/proxmox-backup/ with root as owner (in case it does not exist yet) > > Signed-off-by: Oguz Bektas > --- > src/tape/mod.rs | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/tape/mod.rs b/src/tape/mod.rs > index ed03d8a7..de15800f 100644 > --- a/src/tape/mod.rs > +++ b/src/tape/mod.rs > @@ -85,7 +85,7 @@ pub fn create_drive_state_dir() -> Result<(), Error> { > .owner(backup_user.uid) > .group(backup_user.gid); > > - create_path(DRIVE_STATE_DIR, None, Some(options)) > + create_path(DRIVE_STATE_DIR, Some(options.clone()), Some(options)) > .map_err(|err: Error| format_err!("unable to create drive state dir - {}", err))?; > > Ok(()) > @@ -100,7 +100,7 @@ pub fn create_changer_state_dir() -> Result<(), Error> { > .owner(backup_user.uid) > .group(backup_user.gid); > > - create_path(CHANGER_STATE_DIR, None, Some(options)) > + create_path(CHANGER_STATE_DIR, Some(options.clone()), Some(options)) > .map_err(|err: Error| format_err!("unable to create changer state dir - {}", err))?; > > Ok(()) > -- > 2.20.1 > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel