From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A44E09AE92 for ; Mon, 16 Oct 2023 13:57:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 849CD17585 for ; Mon, 16 Oct 2023 13:57:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 16 Oct 2023 13:57:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 626D94104A for ; Mon, 16 Oct 2023 13:57:42 +0200 (CEST) Content-Type: multipart/alternative; boundary="------------cX0TBsc0qtzke9n1kntugIUU" Message-ID: <907a68a9-5a68-4631-9a70-b13e570e3cf8@proxmox.com> Date: Mon, 16 Oct 2023 13:57:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Thomas Lamprecht , Dominik Csapak , Proxmox Backup Server development discussion References: <20230913142045.240835-1-g.goller@proxmox.com> <9912014b-0ad8-4cf8-9ce7-8b46a553b55b@proxmox.com> <83b3341d-9b14-4c0d-9265-65fb9d95dcfe@proxmox.com> <92df7c1a-2691-4971-93a8-22bc9d260ed8@proxmox.com> <87356f09-673e-4ae8-ba0a-9cedc30e5572@proxmox.com> <5f00418c-adfe-4e4a-8f5c-8e0b80e1ff1c@proxmox.com> <1d8ff790-3e6c-435d-a58d-5a7ab32245fb@proxmox.com> From: Gabriel Goller In-Reply-To: <1d8ff790-3e6c-435d-a58d-5a7ab32245fb@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.330 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy HTML_MESSAGE 0.001 HTML included in message KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix: ui: spinner position X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2023 11:57:44 -0000 This is a multi-part message in MIME format. --------------cX0TBsc0qtzke9n1kntugIUU Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/16/23 12:04, Thomas Lamprecht wrote: > [..] > To clarify, I'd explicitly only left-align those spinners for when > used as job running spinners, not for loading – and IIRC we do not > have any per-cell or per-row loading indicators anyway, as we always > load all data of a grid at once (or at least fake doing so), but never > row or even cell-wise. Oh, ok, got it. > So moving this new alignment behavior into its own class, that derives > from the ExtJS one, seems more reasonable to avoid odd rendering issues > for the cases where the left-alignment isn't desired. > > If we then add a text to that is an independent decision, but it surely > wouldn't hurt accessibility. Ok, so I think I'll move the current `x-grid-row-loading` class to the `proxmox-widget-toolkit/src/css/ext-6-pmx.css` file and create a new class `x-grid-row-loading-left` (with the 10px margin left). I'll also have to edit the `proxmox-dark/*.scss` files so that the logo is shown correctly in the darkmode. To add the text I would simply return a `` tag with a margin left of 20px (more or less, to make place for the icon) and have the translated text as a content. Returning the icon directly as a `` tag isn't that simple, I'd had to attach the whole styling + the conditional dark mode stuff. LMK what you think! --------------cX0TBsc0qtzke9n1kntugIUU Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

On 10/16/23 12:04, Thomas Lamprecht wrote:

[..] 
To clarify, I'd explicitly only left-align those spinners for when
used as job running spinners, not for loading – and IIRC we do not
have any per-cell or per-row loading indicators anyway, as we always
load all data of a grid at once (or at least fake doing so), but never
row or even cell-wise.
Oh, ok, got it. 
So moving this new alignment behavior into its own class, that derives
from the ExtJS one, seems more reasonable to avoid odd rendering issues
for the cases where the left-alignment isn't desired.

If we then add a text to that is an independent decision, but it surely
wouldn't hurt accessibility.
Ok, so I think I'll move the current `x-grid-row-loading` class to the
`proxmox-widget-toolkit/src/css/ext-6-pmx.css` file and create a new
class `x-grid-row-loading-left` (with the 10px margin left). I'll also
have to edit the `proxmox-dark/*.scss` files so that the logo is shown
correctly in the darkmode. To add the text I would simply return a `<span>`
tag with a margin left of 20px (more or less, to make place for the icon)
and have the translated text as a content.

Returning the icon directly as a `<img>` tag isn't that simple, I'd had to
attach the whole styling + the conditional dark mode stuff.

LMK what you think!

--------------cX0TBsc0qtzke9n1kntugIUU--