From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D2138EBE9 for ; Wed, 27 Sep 2023 16:45:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B49F1DA45 for ; Wed, 27 Sep 2023 16:45:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 27 Sep 2023 16:45:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EE82748E34 for ; Wed, 27 Sep 2023 16:45:38 +0200 (CEST) Message-ID: <9059a6a9-8bb1-bd72-1eb5-c9e939a0e6ef@proxmox.com> Date: Wed, 27 Sep 2023 16:45:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Content-Language: en-US To: =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= , Proxmox Backup Server development discussion References: <20230908114409.178087-1-g.goller@proxmox.com> <20230908114409.178087-2-g.goller@proxmox.com> <1695810472.h674oam6kl.astroid@yuna.none> From: Gabriel Goller In-Reply-To: <1695810472.h674oam6kl.astroid@yuna.none> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.373 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.473 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [gnu.org] Subject: Re: [pbs-devel] [PATCH proxmox v3] router: cli: added `ask_for_confirmation` helper X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Sep 2023 14:45:40 -0000 On 9/27/23 12:48, Fabian Grünbichler wrote: > On September 27, 2023 12:13 pm, Wolfgang Bumiller wrote: >> On Fri, Sep 08, 2023 at 01:44:09PM +0200, Gabriel Goller wrote: >>> Added `ask_for_confirmation` helper that outputs a prompt and >>> lets the user confirm or deny it. Also added localization using >>> `libc::nl_langinfo()` to match/show a `yes` or `no` in the correct >>> language. >>> Implemented to close #4763. >>> >>> Signed-off-by: Gabriel Goller >>> --- >>> >>> update v3: >>> - added localization using `libc::nl_langinfo` >>> >>> note: skipped to version 3, so that the whole patch series has >>> the same version number. >>> >> [..] >>> + use std::ffi::CStr; >>> + let yes_expr = unsafe { CStr::from_ptr(libc::nl_langinfo(libc::YESEXPR)) } >>> + .to_str() >>> + .unwrap_or("^[yY]$"); >>> + let no_expr = unsafe { CStr::from_ptr(libc::nl_langinfo(libc::NOEXPR)) } >>> + .to_str() >>> + .unwrap_or("^[nN]$"); >>> + >>> + let n = no_expr.chars().find(|c| c.is_uppercase()).unwrap_or('N'); >>> + let y = yes_expr.chars().find(|c| c.is_uppercase()).unwrap_or('Y'); >>> + print!("{query} [{y}/{n}]: "); >> Usually, the uppercase letter is used for the default for when typing >> nothing, while the other one is lowercase. >> >> Now I was also wondering what we should do if no upper/lowercase letter >> exists, but then again, it seems yY and nN are pretty much always >> included. I checked at least de_DE, ja_JP and zh_CN next to en_US, and >> I'm fairly certain we can rely on that, since I'm assuming this is >> exactly what `rpmatch(3)` does, which explicitly states that `y` and `n` >> work regardless of locale. > there definitely are locales that either don't include 'y' and/or 'n', > or do so in a misleading manner. > > one example: > > $ LC_MESSAGES=sw_KE.UTF-8 locale yesexpr > ^[+1nNyY] > > $ LC_MESSAGES=sw_KE.UTF-8 locale noexpr > ^[-0hHlL] > > this is also the case for nl_langinfo, at least if the code in question > actually calls setlocale/uselocale at some point, which we don't do I > think? oh, yeah right, we never called it. I can add this lines before using `nl_langinfo`: ``` unsafe { libc::setlocale(libc::LC_ALL, empty_cstring.as_ptr()) }; ``` this uses the environment locale on the system [0]. > in any case, I am not sure whether localizing just the prompt answers > makes much sense, if we don't localize log messages/CLI output/.. in > general? Hmm, it *could* be useful for inputs though, especially those that need to be matched. Think of keyboards in different languages. [0]: https://www.gnu.org/software/libc/manual/html_node/Setting-the-Locale.html