From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4E1301FF15E for <inbox@lore.proxmox.com>; Fri, 9 Aug 2024 13:12:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 76BF13CB19; Fri, 9 Aug 2024 13:12:14 +0200 (CEST) Message-ID: <8e15f2b6-4408-4ce2-9022-e942fd5d61d6@proxmox.com> Date: Fri, 9 Aug 2024 13:12:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Christoph Heiss <c.heiss@proxmox.com> References: <20240716134514.1656795-1-c.heiss@proxmox.com> <d368ccd2-5c2f-4054-aa2d-4299c2d52b6d@proxmox.com> <xl6f7r5kgkafhhnvzs3e3qnqf5gmqrjrb6yyrl775y5tpipecx@eybahq3adgyc> <kl2wqxl3qp744fgcgnglfpt33glinbfdxzeryzzwpzhct5rs3a@xfbq6rpqcfnl> Content-Language: de-AT, en-US From: Lukas Wagner <l.wagner@proxmox.com> In-Reply-To: <kl2wqxl3qp744fgcgnglfpt33glinbfdxzeryzzwpzhct5rs3a@xfbq6rpqcfnl> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup/pwt 0/14] fix #5379: introduce default auth realm option X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Cc: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> On 2024-08-08 16:25, Christoph Heiss wrote: > Following up on this: PVE has the exact same behaviour. The login dialog > component (`Proxmox.form.RealmComboBox`, living in > proxmox-widget-toolkit) is in fact reused between both frontends. ah yeah, I think I tried to reproduce this on PVE *before* I fully realized to exact steps to trigger it... > > PVE uses the key `ext-pveloginrealm` in local storage, PBS > `ext-pbs-pveloginrealm`. > > So IMHO either we should keep the behaviour as-is or change it for both, > the latter preferably as a separate changeset. > > I would even argue to keep the behaviour, since it makes sense to me - > if a user once logs in using a specific realm, he will probably want to > *always* log in with that realm. > > What do you think? Intuitively I'd expect this feature to work the other way round: - If a default is set, select that one - If not, take the one that was previously selected - fallback to PAM The current behavior definitely took my by surprise. But I think this is a matter of taste, so other opinions would be valuable here as well. Whichever approach we choose, a short paragraph in the docs would definitely be a good idea :) -- - Lukas _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel