From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 1A9021FF17A
	for <inbox@lore.proxmox.com>; Tue, 11 Nov 2025 11:21:27 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 9B10F452E;
	Tue, 11 Nov 2025 11:22:12 +0100 (CET)
Message-ID: <8d3f75d4-15d6-4fcf-b08d-3fd6848319ac@proxmox.com>
Date: Tue, 11 Nov 2025 11:22:10 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>, Nicolas Frey <n.frey@proxmox.com>
References: <20251110084417.173290-1-n.frey@proxmox.com>
 <20251110084417.173290-4-n.frey@proxmox.com>
Content-Language: en-US, de-DE
In-Reply-To: <20251110084417.173290-4-n.frey@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1762856507252
X-SPAM-LEVEL: Spam detection results:  0
 AWL -1.252 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 ENA_SUBJ_ODD_CASE         2.6 Subject has odd case
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox v3 3/3] pbs-api-types: use
 worker-threads schema for TapeBackupJobSetup
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>


Reviewed-by: Christian Ebner <c.ebner@proxmox.com>

On 11/10/25 9:44 AM, Nicolas Frey wrote:
> use new worker-threads schema
> 
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
> ---
>   pbs-api-types/src/jobs.rs | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/pbs-api-types/src/jobs.rs b/pbs-api-types/src/jobs.rs
> index 2b9cef38..ba2af6d7 100644
> --- a/pbs-api-types/src/jobs.rs
> +++ b/pbs-api-types/src/jobs.rs
> @@ -321,11 +321,8 @@ pub struct VerificationJobStatus {
>               optional: true,
>           },
>           "worker-threads": {
> -            type: Integer,
> +            schema: crate::WORKER_THREADS_SCHEMA,
>               optional: true,
> -            minimum: 1,
> -            maximum: 32,
> -            default: 1,
>           },
>       }
>   )]
> @@ -353,7 +350,6 @@ pub struct TapeBackupJobSetup {
>       pub ns: Option<BackupNamespace>,
>       #[serde(skip_serializing_if = "Option::is_none", default)]
>       pub max_depth: Option<usize>,
> -    /// Set the number of worker threads to use for the job
>       #[serde(skip_serializing_if = "Option::is_none")]
>       pub worker_threads: Option<u64>,
>   }



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel