[pbs-devel] [PATCH proxmox-backup] fix #5233: don't require root for some tape operations

* [pbs-devel] [PATCH proxmox-backup] fix #5233: don't require root for some tape operations
@ 2024-09-10  7:08 Dominik Csapak
  2024-11-12 20:15 ` Thomas Lamprecht
  2024-11-13 11:38 ` Dominik Csapak
  0 siblings, 2 replies; 5+ messages in thread
From: Dominik Csapak @ 2024-09-10  7:08 UTC (permalink / raw)
  To: pbs-devel

instead, require 'Tape.Write' on '/tape' path.
This makes it possible for a TapeAdmin or TapeOperator to
format/remove/vault tapes, instead of just root@pam.

I opted for the path '/tape' since we don't have a dedicated acl
structure for single tapes, just '/tape/pool' (which does not apply
since not all tapes have to have a pool), '/tape/device' (which is
intended for drives/changers) and '/tape/jobs' (which is for jobs only).

Alternatively we could invent a new scheme for tape media, e.g.
'/tape/media' for this.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/api2/tape/media.rs | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/src/api2/tape/media.rs b/src/api2/tape/media.rs
index a7c8483a..a480ae17 100644
--- a/src/api2/tape/media.rs
+++ b/src/api2/tape/media.rs
@@ -9,7 +9,7 @@ use proxmox_uuid::Uuid;
 use pbs_api_types::{
     Authid, MediaContentEntry, MediaContentListFilter, MediaListEntry, MediaPoolConfig,
     MediaSetListEntry, MediaStatus, CHANGER_NAME_SCHEMA, MEDIA_LABEL_SCHEMA,
-    MEDIA_POOL_NAME_SCHEMA, MEDIA_UUID_SCHEMA, PRIV_TAPE_AUDIT, VAULT_NAME_SCHEMA,
+    MEDIA_POOL_NAME_SCHEMA, MEDIA_UUID_SCHEMA, PRIV_TAPE_AUDIT, PRIV_TAPE_WRITE, VAULT_NAME_SCHEMA,
 };
 use pbs_config::CachedUserInfo;
 
@@ -305,6 +305,9 @@ pub async fn list_media(
             },
         },
     },
+    access: {
+        permission: &Permission::Privilege(&["tape"], PRIV_TAPE_WRITE, false),
+    },
 )]
 /// Change Tape location to vault (if given), or offline.
 pub fn move_tape(
@@ -362,6 +365,9 @@ pub fn move_tape(
             },
         },
     },
+    access: {
+        permission: &Permission::Privilege(&["tape"], PRIV_TAPE_WRITE, false),
+    },
 )]
 /// Destroy media (completely remove from database)
 pub fn destroy_media(
@@ -553,6 +559,9 @@ pub fn get_media_status(uuid: Uuid) -> Result<MediaStatus, Error> {
             },
         },
     },
+    access: {
+        permission: &Permission::Privilege(&["tape"], PRIV_TAPE_WRITE, false),
+    },
 )]
 /// Update media status (None, 'full', 'damaged' or 'retired')
 ///
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 5+ messages in thread