From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 30C981FF38A for ; Fri, 14 Jun 2024 11:54:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D8437A8D1; Fri, 14 Jun 2024 11:54:34 +0200 (CEST) Message-ID: <8c68a79e-8592-4cc4-ad9e-5934dd86a3cd@proxmox.com> Date: Fri, 14 Jun 2024 11:54:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Gabriel Goller , pbs-devel@lists.proxmox.com References: <20240614093940.149087-1-g.goller@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20240614093940.149087-1-g.goller@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mount.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup v2] client: mount: flush output before exiting X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 6/14/24 11:39, Gabriel Goller wrote: > When using the `proxmox-backup-client mount` command, the parent sometimes > exits before we can print any error message. Most notably this happens > when no PBS_REPOSITORY is passed, as this is the first option checked. > Flush the stdout and stderr so that we can guarantee the output. > > Reported-by: Friedrich Weber > Suggested-by: Christian Ebner > Signed-off-by: Gabriel Goller > --- > > v2, thanks @Christian: > - Removed unneeded pw.try_clone() > > proxmox-backup-client/src/mount.rs | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/proxmox-backup-client/src/mount.rs b/proxmox-backup-client/src/mount.rs > index b69e7e80..e7718b84 100644 > --- a/proxmox-backup-client/src/mount.rs > +++ b/proxmox-backup-client/src/mount.rs > @@ -1,6 +1,7 @@ > use std::collections::HashMap; > use std::ffi::OsStr; > use std::hash::BuildHasher; > +use std::io::{self, Write}; > use std::os::unix::io::{AsRawFd, OwnedFd}; > use std::path::{Path, PathBuf}; > use std::sync::Arc; > @@ -189,7 +190,10 @@ fn mount( > Ok(ForkResult::Child) => { > drop(pr); > nix::unistd::setsid().unwrap(); > - proxmox_async::runtime::main(mount_do(param, Some(pw))) > + let result = proxmox_async::runtime::main(mount_do(param, Some(pw))); > + io::stdout().flush()?; > + io::stderr().flush()?; > + result > } > Err(_) => bail!("failed to daemonize process"), > } Looks good to me now, consider: Reviewed-by: Christian Ebner _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel