From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 21EFA6A156 for ; Tue, 15 Mar 2022 15:38:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 144261FBDD for ; Tue, 15 Mar 2022 15:38:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8CB741FBD2 for ; Tue, 15 Mar 2022 15:38:03 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 636A7428A4 for ; Tue, 15 Mar 2022 15:38:03 +0100 (CET) Message-ID: <8be9527f-3d77-4173-9a73-ffab494334b6@proxmox.com> Date: Tue, 15 Mar 2022 15:38:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Markus Frank References: <20220315130829.49080-1-m.frank@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220315130829.49080-1-m.frank@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #3934 tape owner-selector to Authid X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2022 14:38:34 -0000 On 15.03.22 14:08, Markus Frank wrote: > changed pmxUserSelector to pbsAuthidSelector, because it is currently > not possible to restore with a api token via gui. > > Signed-off-by: Markus Frank > --- > www/tape/window/TapeRestore.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js > index 7a5d3cbf..2322d352 100644 > --- a/www/tape/window/TapeRestore.js > +++ b/www/tape/window/TapeRestore.js > @@ -398,10 +398,10 @@ Ext.define('PBS.TapeManagement.TapeRestoreWindow', { > renderer: Ext.String.htmlEncode, > }, > { > - xtype: 'pmxUserSelector', > + xtype: 'pbsAuthidSelector', > name: 'owner', > fieldLabel: gettext('Owner'), > - emptyText: gettext('Current User'), > + emptyText: gettext('Current Authentication'), We do not use "Authentication" in any gettext currently, besides indirectly in TFA, and for that specific use case we agreed on using "Auth ID", so can you please change it to that in a v2? > value: null, > allowBlank: true, > skipEmptyText: true,