From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5B45D6B501; Tue, 16 Mar 2021 20:57:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 483E9270EA; Tue, 16 Mar 2021 20:57:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id CC413270DD; Tue, 16 Mar 2021 20:57:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5299D45921; Tue, 16 Mar 2021 20:57:17 +0100 (CET) Message-ID: <8bde152e-5f58-5373-be99-da9060999642@proxmox.com> Date: Tue, 16 Mar 2021 20:57:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:87.0) Gecko/20100101 Thunderbird/87.0 Content-Language: en-US To: Proxmox VE development discussion , Stefan Reiter , pbs-devel@lists.proxmox.com References: <20210315141457.7gjd4j6la4cyjvbx@wobu-vie.proxmox.com> <20210315154124.22171-1-s.reiter@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210315154124.22171-1-s.reiter@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.047 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [pve-devel] [PATCH pve-qemu v3] add alloc-track block driver patch X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2021 19:57:48 -0000 On 15.03.21 16:41, Stefan Reiter wrote: > See added patches for more info, overview: > 0044: slightly increase PBS performance by reducing allocations > 0045: slightly increase block-stream performance for Ceph > 0046: don't crash with block-stream on RBD > 0047: add alloc-track driver for live restore > > Signed-off-by: Stefan Reiter > --- > > v3: > * improve track_drop as discussed by @Wolfgang, both on and off list > (DropState, additional bdrv_ref/unref) > > track_drop is certainly not beautiful, but it works reliably in our use-case... > > ...st-path-reads-without-allocation-if-.patch | 52 +++ > ...PVE-block-stream-increase-chunk-size.patch | 23 ++ > ...accept-NULL-qiov-in-bdrv_pad_request.patch | 42 ++ > .../0047-block-add-alloc-track-driver.patch | 391 ++++++++++++++++++ > debian/patches/series | 4 + > 5 files changed, 512 insertions(+) > create mode 100644 debian/patches/pve/0044-PVE-block-pbs-fast-path-reads-without-allocation-if-.patch > create mode 100644 debian/patches/pve/0045-PVE-block-stream-increase-chunk-size.patch > create mode 100644 debian/patches/pve/0046-block-io-accept-NULL-qiov-in-bdrv_pad_request.patch > create mode 100644 debian/patches/pve/0047-block-add-alloc-track-driver.patch > > applied, thanks! I'd feel more comfortable with the bdrv_pad_request change being upstreamed rather soonish... Maybe one could also build a reasonable case for the alloc-track to be accepted upstream someday..