From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 6E5F91FF146 for ; Tue, 21 Jul 2026 07:45:23 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D8DC7214B2; Tue, 21 Jul 2026 07:45:22 +0200 (CEST) Message-ID: <8b1bba8f-b705-472f-96c2-9d2b42c5eee0@proxmox.com> Date: Tue, 21 Jul 2026 07:45:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox{,-backup} 0/3] add flag to opt-in using node proxy config for s3 connections To: Christian Ebner , pbs-devel@lists.proxmox.com References: <20260511151924.901315-1-c.ebner@proxmox.com> Content-Language: en-US, de-AT From: Robert Obkircher In-Reply-To: <20260511151924.901315-1-c.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784612691655 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.290 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OICUIPUSPX6PTG3VZU7Q7TAHMULWCJCW X-Message-ID-Hash: OICUIPUSPX6PTG3VZU7Q7TAHMULWCJCW X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: nit: commit message 2/3 has a typo "explicitley" I tested that backups stopped working whenever the checkbox was enabled while a bogus http proxy was configured. I also verified that they succeeded when it pointed to tinyproxy on localhost:8888. Reviewed-by: Robert Obkircher Tested-by: Robert Obkircher On 11.05.26 17:17, Christian Ebner wrote: > Currently, if set the node proxy config is used unconditionally also > for S3 client API connections. Since this is however not always the > intention, allow users to expliciteley opt-in for individual S3 > endpoint configurations. > > Reported in the community forum: > https://forum.proxmox.com/threads/183436/ > > > proxmox: > > Christian Ebner (1): > s3-client: add flag to opt-in for using node proxy for connections > > proxmox-s3-client/src/api_types.rs | 8 ++++++++ > 1 file changed, 8 insertions(+) > > > proxmox-backup: > > Christian Ebner (2): > api: config: allow editing the use-node-config flag for s3 endpoints > ui: add opt-in flag for using the node proxy config for s3 connections > > pbs-datastore/src/datastore.rs | 14 ++++++++++++-- > src/api2/admin/s3.rs | 8 +++++++- > src/api2/config/s3.rs | 16 +++++++++++++++- > www/window/S3ClientEdit.js | 13 +++++++++++++ > 4 files changed, 47 insertions(+), 4 deletions(-) > > > Summary over all repositories: > 5 files changed, 55 insertions(+), 4 deletions(-) >