From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CF3711FF173 for ; Mon, 25 Nov 2024 14:23:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 10CB713874; Mon, 25 Nov 2024 14:23:58 +0100 (CET) Message-ID: <8a7a5150-9449-4d3b-b3a0-078aaa8fdcd6@proxmox.com> Date: Mon, 25 Nov 2024 14:23:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Backup Server development discussion , Hannes Laimer References: <20241122144713.299130-1-h.laimer@proxmox.com> <20241122144713.299130-20-h.laimer@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20241122144713.299130-20-h.laimer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v14 19/26] ui: maintenance: fix disable msg field if no type is selected X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" one comment inline On 11/22/24 15:47, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > www/window/MaintenanceOptions.js | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/www/window/MaintenanceOptions.js b/www/window/MaintenanceOptions.js > index 1ee92542e..527c36987 100644 > --- a/www/window/MaintenanceOptions.js > +++ b/www/window/MaintenanceOptions.js > @@ -56,12 +56,17 @@ Ext.define('PBS.window.MaintenanceOptions', { > fieldLabel: gettext('Maintenance Type'), > value: '__default__', > deleteEmpty: true, > + listeners: { > + change: (field, newValue) => { > + Ext.getCmp('message-field').setDisabled(newValue === '__default__'); i'd rather you use 'itemId' instead and use our 'up().down()' mechanism like we do everywhere else, or use a 'referenceHolder' and 'reference'+'lookup' instead the reason is that (html) id's have to be globally unique, and having one that is generically named 'message-field' might clash with something else at one point... > + }, > + }, > }, > { > xtype: 'proxmoxtextfield', > + id: 'message-field', > name: 'maintenance-msg', > fieldLabel: gettext('Description'), > - // FIXME: disable if maintenance type is none > }, > ], > }, _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel