From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7588370FA3 for ; Tue, 10 May 2022 09:48:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6B90847B2 for ; Tue, 10 May 2022 09:48:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A7A0C47A7 for ; Tue, 10 May 2022 09:47:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7A32B4325B for ; Tue, 10 May 2022 09:47:59 +0200 (CEST) Message-ID: <89866f9d-7e08-6f05-bd43-e5c28b1c8935@proxmox.com> Date: Tue, 10 May 2022 09:47:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Thunderbird/101.0 Content-Language: en-GB To: Proxmox Backup Server development discussion , Dominik Csapak References: <20220509140906.3488498-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220509140906.3488498-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pbs-devel] applied: [PATCH proxmox-backup v2] chunk_store: insert_chunk: write chunk again if it is empty on disk X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 May 2022 07:48:30 -0000 Am 5/9/22 um 16:09 schrieb Dominik Csapak: > and issue a warning. We can do this, because we know an empty chunk cannot be > valid, and we (assumedly) have a valid chunk in memory. > > Having empty chunks on disk is currently possible when PBS crashes, but the > rename of the chunk was flushed to disk, when the actual data was not. > > If it's not empty but there is a size mismatch, return an error. > > Signed-off-by: Dominik Csapak > --- > replaces: https://lists.proxmox.com/pipermail/pbs-devel/2022-May/005042.html > > changes from v1: > * warn only on old_size == 0 > * fix old_size/new_size > * expand commit message > > we could do further checks here, but those should be caught by verify. > the 'real' fix for most of the 0-size chunks will be to either fsync > the chunks after write/rename, or do a syncfs before the backup ends > > pbs-datastore/src/chunk_store.rs | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > applied, thanks!