From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5FFAA92346 for ; Fri, 16 Feb 2024 18:55:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3FDFC6BA4 for ; Fri, 16 Feb 2024 18:55:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 16 Feb 2024 18:55:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4A1D84061B for ; Fri, 16 Feb 2024 18:55:34 +0100 (CET) Message-ID: <883fd963-22b0-49c2-aa41-2c68afa666de@proxmox.com> Date: Fri, 16 Feb 2024 18:55:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pbs-devel@lists.proxmox.com References: <20240216153317.323260-1-g.goller@proxmox.com> <2700a390-50ee-47f4-8fec-aa38184c440f@proxmox.com> Content-Language: en-US From: Max Carrara In-Reply-To: <2700a390-50ee-47f4-8fec-aa38184c440f@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.006 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [command.rs, create.rs, proxmox.com] Subject: Re: [pbs-devel] [PATCH proxmox{, -backup} 0/4] output full anyhow context in client X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Feb 2024 17:55:35 -0000 On 2/16/24 18:49, Max Carrara wrote: > On 2/16/24 16:33, Gabriel Goller wrote: >> Instead of using format_err! and format! to create error messages, we >> want to move to anyhow::Context and add information to already >> existing anyhow::Error's. >> Before we start to gradually phase out the format! error calls, we >> need to print the whole context + error, because the default >> anyhow::Error Display implementation doesn't print the actual error. >> >> This series starts with the proxmox-backup-client and includes a patch >> from Fabian that introduces pretty-printing of errors (including >> the context) and some other high-level stuff from me. The scope >> is not to remove every format call and add a context everywhere, >> but to enable this change in the future. >> > > Some comments inline, but otherwise a good way to clean up some of our > error handling and how we display things. Will test on Monday, but apart > from what I've already mentioned, looks pretty good! > > Reviewed-by: Max Carrara Oh, one more thing I forgot to mention: Run `cargo fmt` please ;) > >> >> >> proxmox: >> >> Fabian Grünbichler (1): >> CLI: print fatal errors including causes >> >> proxmox-router/src/cli/command.rs | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> >> proxmox-backup: >> >> Gabriel Goller (3): >> pxar: remove ArchiveError >> pxar: add UniqueContext helper >> pxar: use anyhow::Error in PxarBackupStream >> >> pbs-client/src/pxar/create.rs | 49 ++++++++++++++-------------- >> pbs-client/src/pxar_backup_stream.rs | 20 +++++++----- >> 2 files changed, 35 insertions(+), 34 deletions(-) >> >> >> Summary over all repositories: >> 3 files changed, 37 insertions(+), 36 deletions(-) >> > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel