From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 198ED1FF17C
	for <inbox@lore.proxmox.com>; Fri, 29 Nov 2024 14:13:03 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id DC86C194E8;
	Fri, 29 Nov 2024 14:13:05 +0100 (CET)
Message-ID: <88232a5c-0180-4189-9c5c-7684ca92ec54@proxmox.com>
Date: Fri, 29 Nov 2024 14:12:33 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>,
 =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
References: <20241128145440.4119007-1-d.csapak@proxmox.com>
 <771443181.1837.1732867036375@webmail.proxmox.com>
 <ae0dba6b-c079-41ed-8c17-313d7a05de06@proxmox.com>
 <ed920f89-2511-4fe0-8a6c-f92dd6561d8d@proxmox.com>
 <370c1808-5812-4c19-a084-3313243b3771@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <370c1808-5812-4c19-a084-3313243b3771@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.016 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [musl-libc.org]
Subject: Re: [pbs-devel] [PATCH proxmox] sys: fs: set FD_CLOEXEC when
 creating temp files
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>

On 11/29/24 13:31, Thomas Lamprecht wrote:
> Am 29.11.24 um 11:21 schrieb Thomas Lamprecht:
>> Am 29.11.24 um 09:02 schrieb Dominik Csapak:
>>> the question for me is if it's ok to use since mkostemp is only a glibc extension (since 2.7) and we
>>> may use that in proxmox-backup-client which we want to statically build ?
>>> (not sure how that static compilation works with such a thing though...)
>>
>> FWIW, it's supported by MUSL:
>>
>> http://git.musl-libc.org/cgit/musl/tree/src/temp/mkostemp.c
> 
> And just to clarify, the rust libc crate supports different libc targets and
> exposes mkostemp among others (all?) for both, the GNU libc a musl libc
> targets.
> 
> So using that method might be indeed the best option for now and should not
> hinder any static builds, as if not with glibc then we highly probably do
> them with musl.

great, thanks for looking that up. I'll send a v2 with using mkostemp
(with a small nix like wrapper around, so we can it as a drop in replacement,
and maybe send it upstream?)




_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel