From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BA6CBB832E for ; Thu, 7 Mar 2024 14:17:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 96F8F36956 for ; Thu, 7 Mar 2024 14:16:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 7 Mar 2024 14:16:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7962548885 for ; Thu, 7 Mar 2024 14:16:51 +0100 (CET) From: Stefan Lendl To: pbs-devel@lists.proxmox.com In-Reply-To: <20240221095843.488582-1-git@stfl.dev> References: <20240208135953.2078165-1-s.lendl@proxmox.com> <20240221095843.488582-1-git@stfl.dev> Date: Thu, 07 Mar 2024 14:16:50 +0100 Message-ID: <87le6uji65.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-SPAM-LEVEL: Spam detection results: 0 AWL 0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs, datastore.rs, proxmox-backup-manager.rs, gc.rs] Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 0/8] Add GC job status to datastore and global prune job view. X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2024 13:17:23 -0000 ping, still applies. > From: Stefan Lendl > > Fix #3217: Addition of a new tab "Prune & GC" in "Datastore" and not in each Datastore created > Fix #4723: add last, next run, status, duration to gc > > Extends the garbage collection view to display in addition to the schedule: > - State (of last run) > - Duration (of last run) > - Last Run Date > - Next Run Date (if scheduled) > - Removed Chunks (in last run) > - Pending Chunks (as of last run) > > In the Datastore global overview, the prune view is extended to show the same > details for all availible datastores also the ones without a gc-schedule. > > Allows editing the schedule, showing the log of the last run and manually > running the gc job. In the global view, by selecting the row of the datastore. > > Adds a proxmox-backup-manager cli command to list all gc jobs > `proxmox-backup-manager garbage-collection list` > > > Changes v2 -> v3: > - fixed indentation (how hard can it be?..) > - added git trailers > > Changes v1 -> v2: > - sort imports > - fix eslint warnings > - update columns in GC Job view to fill the entire width > - not include path PruneJobEdit (sent separatly) > > This is based on a series from g.goller > Changes to g.goller's series: > - rename endpoint from gc-info to gc-job-status > - add list-all-gc-jobs endpoint > - UI uses Grid (table) view instead of model grid > - implement GC job view in global view > > Stefan Lendl (8): > api: garbage collect job status > gc: global prune and gc job view > gc: move datastore/PruneAndGC to config/PruneAndGC > gc: hide datastore column in local gc view > ui: order Prune&GC before SyncJobs > cli: list gc jobs with proxmox-backup-manager > gc: show removed and pending chunks of last run in ui > gc: configure width and flex on GC Jobs columns > > pbs-api-types/src/datastore.rs | 40 +++++ > src/api2/admin/datastore.rs | 129 +++++++++++++++- > src/api2/admin/gc.rs | 57 +++++++ > src/api2/admin/mod.rs | 2 + > src/bin/proxmox-backup-manager.rs | 33 ++++ > www/Makefile | 4 +- > www/Utils.js | 6 +- > www/config/GCView.js | 243 ++++++++++++++++++++++++++++++ > www/config/PruneAndGC.js | 52 +++++++ > www/datastore/DataStoreList.js | 11 +- > www/datastore/Panel.js | 3 +- > www/datastore/PruneAndGC.js | 133 ---------------- > www/window/GCJobEdit.js | 28 ++++ > 13 files changed, 593 insertions(+), 148 deletions(-) > create mode 100644 src/api2/admin/gc.rs > create mode 100644 www/config/GCView.js > create mode 100644 www/config/PruneAndGC.js > delete mode 100644 www/datastore/PruneAndGC.js > create mode 100644 www/window/GCJobEdit.js