From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C33E6604B0 for ; Wed, 7 Oct 2020 14:03:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AD80F2E6A5 for ; Wed, 7 Oct 2020 14:03:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 109762E692 for ; Wed, 7 Oct 2020 14:03:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C5BA845C30 for ; Wed, 7 Oct 2020 14:03:50 +0200 (CEST) To: Proxmox Backup Server development discussion , =?UTF-8?Q?Dominic_J=c3=a4ger?= References: <20201007095325.38338-1-d.jaeger@proxmox.com> From: Thomas Lamprecht Message-ID: <8782f8ba-44da-3212-37f7-a4c85394a649@proxmox.com> Date: Wed, 7 Oct 2020 14:03:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: <20201007095325.38338-1-d.jaeger@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.144 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup] Close #3058: ui: RemoteEdit: Add empty texts X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Oct 2020 12:03:51 -0000 On 07.10.20 11:53, Dominic J=C3=A4ger wrote: > Signed-off-by: Dominic J=C3=A4ger > --- > v1->v2: > Make clear that the emptyTexts are not defaults >=20 > www/window/RemoteEdit.js | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) >=20 > diff --git a/www/window/RemoteEdit.js b/www/window/RemoteEdit.js > index 56a248e0..6515dce9 100644 > --- a/www/window/RemoteEdit.js > +++ b/www/window/RemoteEdit.js > @@ -34,7 +34,8 @@ Ext.define('PBS.window.RemoteEdit', { > { > xtype: 'pmxDisplayEditField', > name: 'name', > - fieldLabel: gettext('Remote'), > + fieldLabel: gettext('Remote ID'), > + emptyText: 'E.g., new_remote', I still would rather have something along the lines of: gettext('An unique name to identify this remote.') and that rather as tooltip here, for free choosable names that just feels weird else. > renderer: Ext.htmlEncode, > allowBlank: false, > minLength: 4, > @@ -48,7 +49,8 @@ Ext.define('PBS.window.RemoteEdit', { > name: 'hostport', > submitValue: false, > vtype: 'HostPort', > - fieldLabel: gettext('Host'), > + fieldLabel: gettext('Remote Address'), > + emptyText: 'E.g., 192.168.10.10', I though you wanted to avoid E.g. due to our writing guide? :) Could be instead done as tooltip with a more helping hint: gettext('The DNS or IP address of the remote, optionally with a port.') > listeners: { > change: function(field, newvalue) { > let host =3D newvalue; > @@ -94,7 +96,8 @@ Ext.define('PBS.window.RemoteEdit', { > xtype: 'proxmoxtextfield', > allowBlank: false, > name: 'userid', > - fieldLabel: gettext('Userid'), > + fieldLabel: gettext('User ID'), > + emptyText: 'E.g., admin@pbs', s/E.g./For example/ besides that: this is OK, IMO, User ID is pretty fixed in format (nothing= optional), so a single example shows the user that the @realm part is wan= ted. > }, > { > xtype: 'textfield', > @@ -116,6 +119,7 @@ Ext.define('PBS.window.RemoteEdit', { > deleteEmpty: '{!isCreate}', > }, > fieldLabel: gettext('Fingerprint'), > + emptyText: 'Server certificate SHA-256 fingerprint, required for sel= f-signed certificates', > }, > { > xtype: 'proxmoxtextfield', >=20