From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <s.lendl@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 1C26D9058C
 for <pbs-devel@lists.proxmox.com>; Tue,  2 Apr 2024 13:15:11 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id E7D27468B
 for <pbs-devel@lists.proxmox.com>; Tue,  2 Apr 2024 13:14:40 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pbs-devel@lists.proxmox.com>; Tue,  2 Apr 2024 13:14:40 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0969B4497D;
 Tue,  2 Apr 2024 13:14:40 +0200 (CEST)
From: Stefan Lendl <s.lendl@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>, Proxmox Backup Server development
 discussion <pbs-devel@lists.proxmox.com>
In-Reply-To: <CZRSMABGTBRA.PLTG35RS57W4@proxmox.com>
References: <20240308133625.32282-1-g.goller@proxmox.com>
 <87a5n32143.fsf@gmail.com> <CZRSMABGTBRA.PLTG35RS57W4@proxmox.com>
Date: Tue, 02 Apr 2024 13:14:39 +0200
Message-ID: <877chgkodc.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.025 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup v3] api: make prune-group a
 real workertask
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 02 Apr 2024 11:15:11 -0000

"Gabriel Goller" <g.goller@proxmox.com> writes:

> On Tue Mar 12, 2024 at 11:30 AM CET, Stefan Lendl wrote:
>>
>> LGTM with a slight note below for a style preference.
>>
>> > +    let prune_group = move |worker: Arc<WorkerTask>| {
>> > +        if keep_all {
>> > +            task_log!(worker, "No prune selection - keeping all files.");
>> > +        } else {
>>
>> You don't actually need to spawn a task if you're not doing any work.
>> On the other hand it makes the code slightly simpler and you need the
>> worker, right?
>
> IMO starting a worker is better, because the user sees that something is
> happening... I mean we could also immediately return and show a popup in
> the frontend, but that won't work when the user isn't logged
> in/currently looking at the page. This way he simply sees a prune job in
> the task log which prints 'No prune selection - keeping all files'.
>

Makes sense!