From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 86F0E9A521 for ; Fri, 13 Oct 2023 15:05:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 650C61E873 for ; Fri, 13 Oct 2023 15:04:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 13 Oct 2023 15:04:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0876648F12; Fri, 13 Oct 2023 15:04:55 +0200 (CEST) Message-ID: <87356f09-673e-4ae8-ba0a-9cedc30e5572@proxmox.com> Date: Fri, 13 Oct 2023 15:04:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Thomas Lamprecht , Proxmox Backup Server development discussion , Gabriel Goller References: <20230913142045.240835-1-g.goller@proxmox.com> <9912014b-0ad8-4cf8-9ce7-8b46a553b55b@proxmox.com> <83b3341d-9b14-4c0d-9265-65fb9d95dcfe@proxmox.com> <92df7c1a-2691-4971-93a8-22bc9d260ed8@proxmox.com> From: Dominik Csapak In-Reply-To: <92df7c1a-2691-4971-93a8-22bc9d260ed8@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix: ui: spinner position X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2023 13:05:26 -0000 On 10/13/23 14:38, Thomas Lamprecht wrote: > Am 12/10/2023 um 14:34 schrieb Dominik Csapak: >> On 10/12/23 13:49, Gabriel Goller wrote: >>> On 10/12/23 11:28, Dominik Csapak wrote: >>>> *if* we want to change this, we either would have to adapt pve/pmg as well, >>>> or refactor the class into the widget-toolkit (idk if there are some differences >>>> across products, though it shouldn't be), because we also use that for the task >>>> and job status list (e.g. replication) >>> >>> I looked at them briefly and they have a few things in common, but imo >>> it's not worth the hassle combining them. We wouldn't **need** this in >>> pve/pmg but I could still submit a patch... let me know. >>> >>>> >> >> Depends on your definition of **need**. If we don't do this, >> it would look differently e.g. for the task list in pve/pmg vs pbs >> and we want to have the UI consistent across products >> (except if there is a good reason to diverge) so for me it is >> important to stay consistent here. >> >> @Thomas any opinion on this? > > I find Gabriel has a point, it looks odd as is, and aligning it right > makes it better fit in with other states like "OK" or "Error: ..".) fine with me then > > Having something like "Running" as text here would be nice, but we > cannot just use a `.x-grid-row-loading:after { content: 'Running' }` > as that misses translations. > > One option would be to avoid ExtJS CSS here and use font-awesome like > "fa fa-fw fa-circle-o-notch fa-spin", the only disadvantage from that > is that we lose the site-wide synced animation that the currently used > GIF provides, can be worked around but IIRC there's nothing native > available for doing so. we could also create our own class that uses the gif as a background image, or simply embed the gif directly? then we'd keep the image and could still add a translated text > > For now the adapted CSS would be an OK stop-gap, IIRC we only use such > grid loading classes for such scheduled-job grids. Adding it to PVE > (isn't there even anything besides replication using that?) would be > good too though. IMO no need for widget toolkit, I'd keep this contained > for now. we use that for running tasks and replication, and the class 'x-grid-row-loading' is the same for pve/pmg/pbs (so i thought it might warrant to have it in widget toolkit, so that we can remove it from the individual projects' css files)