From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3A1211FF13F for ; Thu, 09 Apr 2026 11:39:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7AB1C1CC12; Thu, 9 Apr 2026 11:40:33 +0200 (CEST) Message-ID: <86d88446-3214-4aa9-82df-f61f429f856d@proxmox.com> Date: Thu, 9 Apr 2026 11:39:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-backup v8 00/17] partially fix #6563: add s3 counter for statistics and notifications To: Dominik Csapak , pbs-devel@lists.proxmox.com References: <20260402105333.463088-1-c.ebner@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775727531120 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.068 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 675FNPRGRFHOPJ4ZU4CSTSPOTZN2VIU2 X-Message-ID-Hash: 675FNPRGRFHOPJ4ZU4CSTSPOTZN2VIU2 X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 4/9/26 11:33 AM, Dominik Csapak wrote: > didn't look too closely through the backend code yet, but wanted > to give some early feedback: thanks! +1 > aside from the one comment on the summary page, the ui/ux looks > good to me. > > I noticed that in my notifications, the datastore seems to be not set? > I get a notification with > > Threshold Exceeded For Datastore '' > > which seems wrong, but the code looks as if it should be set, so > maybe there is something going on with my setup though... Will have a closer look once time allows > also the series needs a rebase, i applied it on an older commit > and rebased it myself (should be trivial to do from what it looks like) Thanks for pointing this out, will do later today if nothing bigger comes up during your review!