From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3BDB591594 for ; Fri, 7 Oct 2022 11:06:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 17FB623960 for ; Fri, 7 Oct 2022 11:06:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 7 Oct 2022 11:06:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 93597447C7; Fri, 7 Oct 2022 11:06:29 +0200 (CEST) Message-ID: <86a04d9d-ecbe-36c5-a3f0-19f5cb9ae681@proxmox.com> Date: Fri, 7 Oct 2022 11:06:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 To: Thomas Lamprecht , Proxmox Backup Server development discussion , pmg-devel@lists.proxmox.com References: <20220720122256.483511-1-m.heiserer@proxmox.com> <20220720122256.483511-3-m.heiserer@proxmox.com> <677a9e78-033e-dfb5-9057-8b1eff231c96@proxmox.com> Content-Language: en-US From: Matthias Heiserer In-Reply-To: <677a9e78-033e-dfb5-9057-8b1eff231c96@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.863 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.121 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH widget-toolkit] CSS: import action column fix from pbs, pmg X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2022 09:06:31 -0000 On 05.10.2022 17:45, Thomas Lamprecht wrote: > Am 20/07/2022 um 14:22 schrieb Matthias Heiserer: >> So it is in one location and available to pve as well. >> >> Signed-off-by: Matthias Heiserer >> --- >> src/css/ext6-pmx.css | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/src/css/ext6-pmx.css b/src/css/ext6-pmx.css >> index 886e24a..2286003 100644 >> --- a/src/css/ext6-pmx.css >> +++ b/src/css/ext6-pmx.css >> @@ -274,3 +274,18 @@ div.right-aligned { >> /* markdown tables end */ >> >> /* markdown content end */ >> + >> +/* fix action column icons */ >> +.x-action-col-icon:before { >> + color: #555; >> +} >> + >> +.x-action-col-icon { >> + font-size: 13px; >> + height: 13px; >> +} > > this is using the outdated/wrong ones, the font awesome icons we use are 14px. > Please use the modern ones from PBS and maybe add the additional ones, like: > > .x-action-col-icon { > margin: 0 1px; > font-size: 14px; > } > .x-action-col-icon:before, .x-action-col-icon:after { > font-size: 14px; > } > .x-action-col-icon:hover:before, .x-action-col-icon:hover:after { > text-shadow: 1px 1px 1px #AAA; > font-weight: 800; > } > > Note that it's a bit confusing because in PBS the previous & wrong 13px font-size > rule didn't get removed.. Oh, good catch. I was confused myself because I only saw the 13px ones and figured we intentionally use a different size there. Will fix it in v2. > > >> + >> +.x-grid-cell-inner-action-col { >> + padding: 6px 10px 5px; >> +} >> +/* fix action column icons end*/ >> \ No newline at end of file >