From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C0DE21FF173 for <inbox@lore.proxmox.com>; Mon, 25 Nov 2024 14:33:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 04BAD13E9D; Mon, 25 Nov 2024 14:33:23 +0100 (CET) Message-ID: <85d1ba3d-e5f5-4872-b41a-435ba2a60959@proxmox.com> Date: Mon, 25 Nov 2024 14:32:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Lukas Wagner <l.wagner@proxmox.com>, Hannes Laimer <h.laimer@proxmox.com> References: <20241122144713.299130-1-h.laimer@proxmox.com> <064ff027-e4c2-4909-9365-659da6dd1fd3@proxmox.com> Content-Language: en-US From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <064ff027-e4c2-4909-9365-659da6dd1fd3@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v14 00/26] add removable datastores X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> On 11/25/24 14:15, Lukas Wagner wrote: > On 2024-11-22 15:46, Hannes Laimer wrote: >> These patches add support for removable datastores. All removable >> datastores have a backing-device(a UUID) associated with them. Removable >> datastores work like normal ones, just that they can be unplugged. It is >> possible to create a removable datastore, sync backups onto it, unplug >> it and use it on a different PBS. >> >> The datastore path specified is relative to the root of the used device. >> Removable datastores are bind mounted to /mnt/datastore/<NAME>. >> Multiple datastores can be created on a single device, but only device with >> a single datastore on them will be auto-mounted. >> >> When a removable datastore is deleted and 'destroy-data' is set, the >> device has to be mounted. If 'destroy-data' is not set the datastore >> can be deleted even if the device is not present. Removable datastores >> are automatically mounted when plugged in. >> > [snip] > > - Something that also was a bit confusing was the following: > - Attached new disk to my PBS test VM > - Formatted the disk as ext4 using the webui (name: disk1, device: sdb1), opting to NOT create a datastore as part of the formatting process > - Created a removable datastore on the new partition (name: disk1-store, device: sdb1) > -> This led to the partition being mounted twice: > > /dev/sdb1 on /mnt/datastore/disk1 type ext4 (rw,relatime) > /dev/sdb1 on /mnt/datastore/disk1-store type ext4 (rw,relatime) > > -> if 'unmount' is pressed for the datastore, only the second mount is unmounted. This could be confusing > to users who expect to be able to safely remove the disk after unmounting the datastore. > > - For contrast, if while creating the partition one opts to create the removable datastore immediately, > the partition is only mounted once. > > i had slightly different, but also confusing experience did basically the same as Lukas, but my target path was the exact same as the already mounted disk which lead to an 'it's already mounted' error (which yeah was expected, i just created the disk) in that case we could e.g. try to simply use the already mounted path for that? (idk how much work checking if it's the right on, etc. that would involve though...) _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel