From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DFCD8B4BF for ; Mon, 11 Sep 2023 10:37:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B1AA85FE6 for ; Mon, 11 Sep 2023 10:36:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 11 Sep 2023 10:36:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7B8884422E for ; Mon, 11 Sep 2023 10:36:51 +0200 (CEST) Message-ID: <85aec3f3-defb-5823-a46b-9115d1d8ef3c@proxmox.com> Date: Mon, 11 Sep 2023 10:36:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Maximiliano Sandoval References: <20230908133219.247294-1-g.goller@proxmox.com> From: Gabriel Goller In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.318 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.473 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v3] fix #4343: updated `view_task_result` to bail on task failure X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2023 08:37:22 -0000 On 9/11/23 08:56, Maximiliano Sandoval wrote: > > On 9/8/23 15:32, Gabriel Goller wrote: >> Now we make an additional request on >> `api2/json/.../tasks/{upid}/status` to >> get the `exitstatus` of the task. This allows us to `bail` and thus >> get a non-zero exit code in the cli. >> >> Signed-off-by: Gabriel Goller >> --- >> >> changes v2: >>   - removed unrelated cleanup >> >> changes v1: >>   - check on each iteration if the task is finished, then bubble up the >>     original error of the task. This was inpractical though, so we print >>     the error and return a generic error. >> >>   pbs-client/src/task_log.rs | 8 ++++++++ >>   1 file changed, 8 insertions(+) >> >> diff --git a/pbs-client/src/task_log.rs b/pbs-client/src/task_log.rs >> index 0bbb928d..709d0d08 100644 >> --- a/pbs-client/src/task_log.rs >> +++ b/pbs-client/src/task_log.rs >> @@ -96,6 +96,14 @@ pub async fn display_task_log( >>               } >>           } >>   +        let status_path = >> format!("api2/json/nodes/localhost/tasks/{upid_encoded}/status"); >> +        let status_result = client.get(&status_path, None).await?; >> +        if status_result["data"]["status"].as_str() == Some("stopped") >> +            && status_result["data"]["exitstatus"].as_str() != >> Some("OK") >> +        { >> +            bail!("task failed"); > The info about the exit status is not propagated, maybe one could > display it too? Then the error would be duplicated on the console. We already print the whole task log, which includes the error. Including the error in `bail` would produce an output simillar to this: ``` root@debian:~# PBS_LOG=info proxmox-backup-manager pull 18.201 test1 test1 pull datastore 'test1' from '18.201/test1' TASK ERROR: Querying namespaces failed - HTTP error 400 Bad Request - no such datastore 'test1' Error: Querying namespaces failed - HTTP error 400 Bad Request - no such datastore 'test1' root@debian:~# ``` >> +        } >> + >>           Ok(()) >>       }; > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > >