From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C47076941D for ; Mon, 13 Sep 2021 12:38:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C28292904A for ; Mon, 13 Sep 2021 12:38:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4DB4A2903C for ; Mon, 13 Sep 2021 12:38:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 234D3447A7; Mon, 13 Sep 2021 12:38:07 +0200 (CEST) Message-ID: <84271615-32d7-9ada-372a-141d05210406@proxmox.com> Date: Mon, 13 Sep 2021 12:38:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:92.0) Gecko/20100101 Thunderbird/92.0 Content-Language: en-US To: Hannes Laimer , Proxmox Backup Server development discussion References: <20210909134819.2082605-1-d.csapak@proxmox.com> <9128b335-2f1b-5390-57c4-72f36051d8b9@proxmox.com> From: Dominik Csapak In-Reply-To: <9128b335-2f1b-5390-57c4-72f36051d8b9@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 2.040 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.584 Looks like a legit reply (A) POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox/proxmox-backup] add 'pbs-shell' tool X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Sep 2021 10:38:07 -0000 thanks for testing! On 9/13/21 11:36, Hannes Laimer wrote: > I just noticed two things while testing: > - if an endpoint expects a parameter called 'path'(e.g. POST /config > /datastore), the parameter conflicts with the api path itself i'll fix it in the v2 by renaming the variable to 'api-path'. or should i prefix it with 'pbs-shell' or something? (it must be something that will not occur in the normal api) > - even though commands like verify(POST /admin/datastore//verify) > or gc(POST /admin/datastore//gc) are started and run successfully, > `Error: control socket connect failed - Connection refused (os error > 111)` is displayed almost always at the end. after looking at/testing the code a bit closer, i noticed it cannot currently work as i do it: * pbs-shell starts a worker * pbs-shell connects to 8007 for the log * proxy tries to query the worker status via command socket, which does not exists for the pbs-shell i'll have to display the task log manually from the pbs-shell and wait for the worker to finish while i think it *would* be better if we let the proxy/daemon start the worker, there is no way to detect api calls that start a worker before actually executing it... since it's *only* a debug tool, its still fine i think.. alternatively, we can switch to a http client for executing the api entirely... > > Note: For testing I applied the patches on > b65dfff574f44e5a60db3903d2226f4dbe386b7a, I assume the moving of stuff > after that should not effect the functionality > i'll rebase onto master for the v2