From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A16679A1CF for ; Thu, 12 Oct 2023 14:35:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A98A51355E for ; Thu, 12 Oct 2023 14:34:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 12 Oct 2023 14:34:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3E77A44A36; Thu, 12 Oct 2023 14:34:37 +0200 (CEST) Message-ID: <83b3341d-9b14-4c0d-9265-65fb9d95dcfe@proxmox.com> Date: Thu, 12 Oct 2023 14:34:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Gabriel Goller , Proxmox Backup Server development discussion References: <20230913142045.240835-1-g.goller@proxmox.com> <9912014b-0ad8-4cf8-9ce7-8b46a553b55b@proxmox.com> From: Dominik Csapak In-Reply-To: <9912014b-0ad8-4cf8-9ce7-8b46a553b55b@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix: ui: spinner position X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Oct 2023 12:35:11 -0000 On 10/12/23 13:49, Gabriel Goller wrote: > On 10/12/23 11:28, Dominik Csapak wrote: >> *if* we want to change this, we either would have to adapt pve/pmg as well, >> or refactor the class into the widget-toolkit (idk if there are some differences >> across products, though it shouldn't be), because we also use that for the task >> and job status list (e.g. replication) > > I looked at them briefly and they have a few things in common, but imo > it's not worth the hassle combining them. We wouldn't **need** this in > pve/pmg but I could still submit a patch... let me know. > >> Depends on your definition of **need**. If we don't do this, it would look differently e.g. for the task list in pve/pmg vs pbs and we want to have the UI consistent across products (except if there is a good reason to diverge) so for me it is important to stay consistent here. @Thomas any opinion on this?