From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 24584716E7 for ; Mon, 4 Oct 2021 10:29:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 15CE71832C for ; Mon, 4 Oct 2021 10:29:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9B9F11831E for ; Mon, 4 Oct 2021 10:29:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6F3B845492 for ; Mon, 4 Oct 2021 10:29:51 +0200 (CEST) To: Proxmox Backup Server development discussion , Dominik Csapak References: <20211001095655.2678928-1-d.csapak@proxmox.com> From: Dietmar Maurer Message-ID: <8105e11b-b879-24c4-0d6b-ebb5d939dc0a@proxmox.com> Date: Mon, 4 Oct 2021 10:29:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211001095655.2678928-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 0.567 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: datastore/Content: reload in activate listener X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Oct 2021 08:29:52 -0000 applied both patches On 10/1/21 11:56 AM, Dominik Csapak wrote: > when we trigger the first load before the panel was fully created, > there was no load mask for it (but the snapshots would "pop in" on load) > > move the first reload into the 'activate' listener. this will be called > the every time a user opens the content tab of a datastore, so guard > it by a 'firstLoad' bool. > > Signed-off-by: Dominik Csapak > --- > www/datastore/Content.js | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/www/datastore/Content.js b/www/datastore/Content.js > index 57693785..ddc923fd 100644 > --- a/www/datastore/Content.js > +++ b/www/datastore/Content.js > @@ -73,7 +73,6 @@ Ext.define('PBS.DataStoreContent', { > 'backup-time', > ]); > Proxmox.Utils.monStoreErrors(view, this.store); > - this.reload(); // initial load > }, > > reload: function() { > @@ -625,6 +624,17 @@ Ext.define('PBS.DataStoreContent', { > }, > }, > > + listeners: { > + activate: function() { > + let me = this; > + // only load on first activate to not load every tab switch > + if (!me.firstLoad) { > + me.getController().reload(); > + me.firstLoad = true; > + } > + }, > + }, > + > viewConfig: { > getRowClass: function(record, index) { > let verify = record.get('verification');