From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B9A91714E5 for ; Mon, 28 Jun 2021 19:02:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A71252E067 for ; Mon, 28 Jun 2021 19:01:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 80B462E056 for ; Mon, 28 Jun 2021 19:01:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 486594447F for ; Mon, 28 Jun 2021 19:01:56 +0200 (CEST) Message-ID: <80dc2af6-c84d-0de5-79b5-7a9787b6c449@proxmox.com> Date: Mon, 28 Jun 2021 19:01:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Stoiko Ivanov References: <20210628162741.74992-1-s.ivanov@proxmox.com> <20210628162741.74992-3-s.ivanov@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210628162741.74992-3-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.463 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.765 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] acme: plugin: add sleep for dns propagation X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 17:02:27 -0000 "fix #3496: ..." On 28.06.21 18:27, Stoiko Ivanov wrote: > the dns plugin config allow for a specified amount of time to wait for > the TXT record to be set and propagated through DNS. > > This patch adds a sleep for this amount of time. > The log message was taken from the perl implementation in proxmox-acme > for consistency. > > Tested with the powerdns plugin in my test setup. > > Signed-off-by: Stoiko Ivanov > --- > src/acme/plugin.rs | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/src/acme/plugin.rs b/src/acme/plugin.rs > index 5e0e547a..96f64b7d 100644 > --- a/src/acme/plugin.rs > +++ b/src/acme/plugin.rs > @@ -2,6 +2,7 @@ use std::future::Future; > use std::pin::Pin; > use std::process::Stdio; > use std::sync::Arc; > +use std::time::Duration; > > use anyhow::{bail, format_err, Error}; > use hyper::{Body, Request, Response}; > @@ -168,6 +169,13 @@ impl DnsPlugin { > ); > } > > + let validation_delay = self.core.validation_delay.unwrap_or(30) as u64; misses the `if validation_delay > 0 {` for consistency with PVE and PMG. > + task.log(format!( > + "Sleeping {} seconds to wait for TXT record propagation", > + validation_delay > + )); > + tokio::time::sleep(Duration::from_secs(validation_delay)).await; > + This now adds the delay on every action, not only on "setup" like in PVE/PMG - makes no sense to do so for teardown... > Ok(&challenge.url) > } > } >