From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 890AE65D03 for ; Fri, 24 Jul 2020 14:02:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 77634A678 for ; Fri, 24 Jul 2020 14:02:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A40FFA66A for ; Fri, 24 Jul 2020 14:02:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 685F94329A for ; Fri, 24 Jul 2020 14:02:09 +0200 (CEST) Date: Fri, 24 Jul 2020 14:01:40 +0200 (CEST) From: Dietmar Maurer To: Proxmox Backup Server development discussion , Thomas Lamprecht Message-ID: <808935848.14.1595592100554@webmail.proxmox.com> In-Reply-To: <20200724081601.30073-1-t.lamprecht@proxmox.com> References: <20200724081601.30073-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.3-Rev17 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.013 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pbs-devel] applied: [PATCH backup 1/2] client: avoid division by zero in avg speed calculation, be more accurate X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2020 12:02:40 -0000 Why don't you use a single duration.as_secs_f64() and compute speed using floting point? > On 07/24/2020 10:16 AM Thomas Lamprecht wrote: > > > using micros vs. as_secs_f64 allows to have it calculated as usize > bytes, easier to handle - this was also used when it still lived in > upload_chunk_info_stream > > Co-authored-by: Stoiko Ivanov > Signed-off-by: Thomas Lamprecht > --- > src/client/backup_writer.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/client/backup_writer.rs b/src/client/backup_writer.rs > index 7e5adb3..2344045 100644 > --- a/src/client/backup_writer.rs > +++ b/src/client/backup_writer.rs > @@ -264,7 +264,7 @@ impl BackupWriter { > crate::tools::format::strip_server_file_expenstion(archive_name.clone()) > }; > if archive_name != CATALOG_NAME { > - let speed: HumanByte = (uploaded / (duration.as_secs() as usize)).into(); > + let speed: HumanByte = ((uploaded * 1_000_000) / (duration.as_micros() as usize)).into(); > let uploaded: HumanByte = uploaded.into(); > println!("{}: had to upload {} from {} in {}s, avgerage speed {}/s).", archive, uploaded, vsize_h, duration.as_secs(), speed); > } else { > -- > 2.27.0 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel