From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dietmar@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 5C67C72DB6
 for <pbs-devel@lists.proxmox.com>; Wed, 14 Apr 2021 10:51:40 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 4DE95BBD2
 for <pbs-devel@lists.proxmox.com>; Wed, 14 Apr 2021 10:51:40 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id DA0D1BBC5
 for <pbs-devel@lists.proxmox.com>; Wed, 14 Apr 2021 10:51:39 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9D493420E5
 for <pbs-devel@lists.proxmox.com>; Wed, 14 Apr 2021 10:51:39 +0200 (CEST)
Date: Wed, 14 Apr 2021 10:51:24 +0200 (CEST)
From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, 
 Wolfgang Bumiller <w.bumiller@proxmox.com>,
 Dominik Csapak <d.csapak@proxmox.com>
Message-ID: <804431853.2884.1618390284589@webmail.proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.5-Rev5
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.109 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2] api2/tape/restore:
 restore_snapshot_archive: only ignore tape errors
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 14 Apr 2021 08:51:40 -0000

> Now, while this is not happening a lot for the `Other` case, it does
> happen quite a few times for the `Disk` case, so you could also add a
> few little helpers for some "quality of life" improvements:
> 
>     impl RestoreError {
>         fn other<T: ToString>(err: T) -> Self {
>             RestoreError::Other(err.to_string())
>         }
> 
>         fn disk<T: ToString>(err: T) -> Self {
>             RestoreError::Disk(err.to_string())
>         }
> 
>         fn tape<T: Into<Error>>(err: T) -> Self {
>             RestoreError::Tape(err.into())
>         }
>     }

I like that idea, but I don't think it is a good idea to convert Errors to strings.
So I would use:

#[derive(thiserror::Error, Debug)]
pub enum RestoreError {
    #[error("tape error: {0}")]
    Tape(Error),
    #[error("disk error: {0}")]
    Disk(Error),
    #[error("{0}")]
    Other(Error),
}