From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 17C0B1FF189
	for <inbox@lore.proxmox.com>; Tue, 18 Feb 2025 17:16:17 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 5214411766;
	Tue, 18 Feb 2025 17:16:13 +0100 (CET)
Date: Tue, 18 Feb 2025 17:15:39 +0100
From: Gabriel Goller <g.goller@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Message-ID: <7vemof4ooe34hbmbaojmumbb5qnwzpmy443vd7r2fudjlxc7vk@ruloksfxwu6m>
References: <5cettqvqg6i6y2cgihynjjirl4vyl6c5l3ewbn4ydhccpgc6ac@aj5yojr624d4>
 <yyzfsgf2p5k52fk67lsu6jzu42egxjqnfgywuermm75ijm7cwg@v4x56bymmlxq>
 <2cugfnfjfv2robousxhdshdu3rxmyg3bnfdazoyagvn5gglatl@6x4trum24nak>
 <iidtwwpusvqkcqw6sh7e7mqqnlhu37icz5k77ps5wro2nenr7b@gqi7k24dsw4n>
 <4iymtwe46mmc7zn6f2erjkfxhal76ma2xy2fh2d4rk2vaqpik4@7n363ok7f5yf>
 <xgi5aiiutasg2353yvgfalsvmq3at6ivsm3gpny42dce3a7mj7@brxsvu2dduhp>
 <j4r7odcmrgzwjcjtofsrtu3dp6mo4cwl2rjozpxsf4ytze5f5s@65euvf7zi2z7>
 <sb6fqudqt4jrewfugeafluk2czmzh34zkzgzlg4aadtuhinsle@ds3vqwr2wypo>
 <2yyeufgkcyl3nhkztrynakfbj5q5s35afo4mpkpdowjab2pxam@dufv5c2fpui3>
 <hjrmzxu77qslue6xrezepccddwkphyvvkgodzm22mfxyze3hhv@mjk5q7ge63bg>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <hjrmzxu77qslue6xrezepccddwkphyvvkgodzm22mfxyze3hhv@mjk5q7ge63bg>
User-Agent: NeoMutt/20241002-35-39f9a6
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.030 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox v2 1/4] log: rename/move init
 functions
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Cc: Lukas Wagner <l.wagner@proxmox.com>, pbs-devel@lists.proxmox.com
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>

>> > >  * pbs tape pmt
>> > >  * pbs tape pmtx
>> > >  * pbs client
>> > >  * pbs pxar
>> > >  * pbs proxmox-backup-debug
>> > >  * pbs proxmox-backup-manager
>> > >  * pbs proxmox-backup-tape
>> > >  * pbs sg-tape-cmd
>> >
>> > ^ IIRC all of these are CLI tools and should therefore all be case (2) -
>> > although I don't know about how the tape stuff works.
>> > If they do anything else, it would be good to know why and have this
>> > documented either in proxmox-log or in their logging-init functions.
>>
>> All except the proxmox-backup-manager as far as I can see, because that
>> one starts pbs tasks directly.
>>
>> > >  * pbs proxmox-daily-update
>> >
>> > The 'daily-update' may be a special case and could use the journal
>> > directly, but may as well be stderr->journald via its `.service`.
>> > But, yeah, obviously it would make actual tracing/debugging easier with
>> > a proper journald-logger here. So another user of case (1).
>>
>> Agree.

Nevermind actually, proxmox-daily-update calls a workertask, so we need
journald and tasklog layer, similar to the daemon's setup.

Sent a new series: https://lore.proxmox.com/pve-devel/20250218161311.558674-1-g.goller@proxmox.com/


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel