From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 53374D51C for ; Thu, 21 Sep 2023 09:50:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 34DA61D297 for ; Thu, 21 Sep 2023 09:50:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 21 Sep 2023 09:50:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BFE344850F for ; Thu, 21 Sep 2023 09:50:42 +0200 (CEST) Message-ID: <7b74879b-acc5-4c58-aed0-35abfa79a72b@proxmox.com> Date: Thu, 21 Sep 2023 09:50:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Content-Language: en-US To: Lukas Wagner , Proxmox Backup Server development discussion References: <20230915065457.352953-1-h.laimer@proxmox.com> <20230915065457.352953-6-h.laimer@proxmox.com> <9d12f5a9-9700-4485-a34f-38769d35452c@proxmox.com> From: Hannes Laimer In-Reply-To: <9d12f5a9-9700-4485-a34f-38769d35452c@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.723 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.473 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.name] Subject: Re: [pbs-devel] [PATCH proxmox-backup 05/23] api2: admin: add (un)mount endpoint for removable datastores X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2023 07:50:44 -0000 On 9/19/23 15:38, Lukas Wagner wrote: > > > On 9/15/23 08:54, Hannes Laimer wrote: >> +pub fn do_mount_device( >> +        datastore.set_maintenance_mode(None); > > I think this overrides existing maintenance modes... e.g. if a datastore > is 'read-only', unmounted and mounted again, then the 'read-only' mode > will be gone. > Yes, it does. Why should it not? The only situation where that could be a problem is if a removable datastore should not be written to at all, so it would either be unplugged or ro. But in this case, why setup sync jos or backups to a datastore that should not be written to in the first place? >> +        config.set_data(&datastore.name, "datastore", &datastore)?; >> +        pbs_config::datastore::save_config(&config)?; >> + >> +        Ok(()) >> +    } else { >> +        Err(format_err!( >> +            "Datastore '{}' can't be mounted because it is not >> removable.", >> +            &datastore.name >> +        )) >> +    } >> +} >> + > >