From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E4F8761700 for ; Mon, 14 Sep 2020 09:32:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D5FF3DF4F for ; Mon, 14 Sep 2020 09:32:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5A7B4DF42 for ; Mon, 14 Sep 2020 09:32:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2002444BB4 for ; Mon, 14 Sep 2020 09:32:33 +0200 (CEST) To: Proxmox Backup Server development discussion , Dylan Whyte References: <20200911140817.19368-1-d.whyte@proxmox.com> From: Thomas Lamprecht Message-ID: <7adacf0a-0896-d9fc-83e1-25730830d642@proxmox.com> Date: Mon, 14 Sep 2020 09:32:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:81.0) Gecko/20100101 Thunderbird/81.0 MIME-Version: 1.0 In-Reply-To: <20200911140817.19368-1-d.whyte@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.211 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH docs] move custom.css from 'docs/' to 'docs/_static/' X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Sep 2020 07:32:34 -0000 On 9/11/20 4:08 PM, Dylan Whyte wrote: > conf.py sets the variable html_static_path to a folder > named '_static'. This is where sphinx searches for custom > stylesheets, so before this change, custom.css had no effect. I sure did have an effect, a `make install` or a `make proxmox-backup-docs` plus `dpkg -i ./*.deb` should show it also in your build setup, or? Note, that sphinx outputs more than one render, e.g., latex, html (epub and some others would be a possibility too), so the `html_static_path` refers to the html output and I copy it there after the sphinx build of HTML is finished. Note also that this patch breaks any build, as the makefile cannot do the copy any more, that would have been easily caught by testing a single build.. So please, one thing I'd expect people to do before sending patches is at least a simple build test, a more functional test is naturally also expected but if it doesn't even build after ones patch is applied it feels like a waste of reviewers time, which is 100 times more scarce than developer time.. This should not sound to much like scolding, but please ingrain a final build and quick functional test step before you send any patch it in your workflow. Thank you!