From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7A923C1A3A for ; Wed, 17 Jan 2024 10:50:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5E7823FE23 for ; Wed, 17 Jan 2024 10:50:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 17 Jan 2024 10:50:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9CC9B49194 for ; Wed, 17 Jan 2024 10:50:21 +0100 (CET) Message-ID: <79cf8bf3-3eec-400d-bb86-3c51bf3202f5@proxmox.com> Date: Wed, 17 Jan 2024 10:50:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-US To: Proxmox Backup Server development discussion , Stefan Lendl References: <20240111155303.1072675-1-s.lendl@proxmox.com> From: Lukas Wagner In-Reply-To: <20240111155303.1072675-1-s.lendl@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH widget-toolkit/proxmox-backup 00/10] Fix #3115: VLAN Network Interface Configuration X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2024 09:50:53 -0000 On 1/11/24 16:52, Stefan Lendl wrote: > This patch series allows configuration of VLAN network interfaces in the PBS GUI > > * Adds reading and writing of vlan network interface configs from network/interfaces > * Creating and updating of VLAN network interfaces via the API > * Copy the VlanId widget from PVE and enable the Linux VLAN interface type in the GUI > * Unit tests > * Some cleanup to leave touched functions cleaner than before > Gave these changes a try. Mostly works fine, however there is a small bug that prohibits updating existing non-VLAN devices - see other replies for details. I liked how approached testing for these changes, e.g. by adding tests for the existing code first to make sure that your following changes do not break anything. That's always a good idea! -- - Lukas