From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4FDB11FF144 for ; Tue, 10 Mar 2026 19:40:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 14F427871; Tue, 10 Mar 2026 19:40:08 +0100 (CET) Message-ID: <79c907b2-23cd-4ccc-8620-35082f4240ec@proxmox.com> Date: Tue, 10 Mar 2026 19:40:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH v1 proxmox-backup 3/3] api: backup: disallow incremental backups with different index length To: Christian Ebner , Robert Obkircher , pbs-devel@lists.proxmox.com References: <20260310160537.182153-1-r.obkircher@proxmox.com> <20260310160537.182153-4-r.obkircher@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773167969676 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.079 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: POU645MQSKNWQ5BMBTPZ2XBIGWB3KH5K X-Message-ID-Hash: POU645MQSKNWQ5BMBTPZ2XBIGWB3KH5K X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 10.03.26 um 18:15 schrieb Christian Ebner: > On 3/10/26 5:09 PM, Robert Obkircher wrote: >> Restore the previous restrictions because fixed index files are only >> reused for qemu backups where the total size never changes. btw. when increasing a vdisk size we (or others that want to backup a fixed index to PBS) theoretically could reuse the previous bitmap, extend it and mark the new area as dirty for efficiency, so this is not something that is bogus out of principle. Also, a bit more rationale would be appreciated here, especially in combination with sending this along with a quite important bug fix.