From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2C9BDC4E9 for ; Mon, 11 Apr 2022 09:33:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1E3E2C9A for ; Mon, 11 Apr 2022 09:33:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9B493C91 for ; Mon, 11 Apr 2022 09:33:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 68C4E4095D for ; Mon, 11 Apr 2022 09:33:05 +0200 (CEST) Message-ID: <78a07a72-c23c-496e-894a-8a838d70059b@proxmox.com> Date: Mon, 11 Apr 2022 09:33:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Thunderbird/100.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Dylan Whyte , Hannes Laimer References: <20220217171457.72206-1-h.laimer@proxmox.com> <20220217171457.72206-2-h.laimer@proxmox.com> <81a44a2f-4b21-0b78-ef69-071ad7cf2a19@proxmox.com> From: Thomas Lamprecht In-Reply-To: <81a44a2f-4b21-0b78-ef69-071ad7cf2a19@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 1.595 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.086 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup v9 1/6] api-types: add maintenance type X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2022 07:33:36 -0000 On 06.04.22 15:08, Dylan Whyte wrote: >> +pub=C2=A0const=C2=A0MAINTENANCE_MESSAGE_SCHEMA:=C2=A0Schema=C2=A0=3D >> +=C2=A0=C2=A0=C2=A0=C2=A0StringSchema::new("Message=C2=A0describing=C2= =A0the=C2=A0reason=C2=A0for=C2=A0the=C2=A0maintenance.") >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0.format(&MAINTENANCE_= MESSAGE_FORMAT) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0.max_length(32) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0.schema(); > Is 32 characters enough for the message? I would think this is somewhat= limiting,=C2=A0but=C2=A0am=C2=A0open=C2=A0to=C2=A0other=C2=A0opinions. The idea is to start more limited, as opening those up once there's real = world requests for legitimate reasons is easy, but we cannot really easily redu= ce the allowed length ever without breaking older systems. Naturally starting out with a overly strict limit is not much of use eith= er, note that 32 characters is not /that/ strict, infos like "zfs pool disk mainte= nance" (26 chars) fit there easily, but yes it may be limitting for more detaile= d infos. Maybe we could settle for 64 now, that would allow a info message like: "zfs pool disk replacement undergoing until 2022-04-11T10:00Z" (61 chars)= , which is IMO an OK upper limit of what people can be enforced to condense the r= elevant info bits into without being required to play "text golf".