From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3E7F51FF140 for ; Fri, 24 Apr 2026 10:43:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 19280FA54; Fri, 24 Apr 2026 10:43:39 +0200 (CEST) Message-ID: <76dedf1f-dc8c-42da-8d9f-ebb5b6616d09@proxmox.com> Date: Fri, 24 Apr 2026 10:43:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: applied: [PATCH proxmox-backup v8 00/13] fixes #6195: add support for moving groups and namespaces To: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= , pbs-devel@lists.proxmox.com, Thomas Lamprecht References: <20260422133951.192862-1-h.laimer@proxmox.com> <177698386728.726567.11620419590194139855.b4-ty@b4> <1777018910.mv34jbslq9.astroid@yuna.none> Content-Language: en-US From: Hannes Laimer In-Reply-To: <1777018910.mv34jbslq9.astroid@yuna.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777020121702 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.080 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BNYXXZTY5UZQ2WEE2755ERBN2EZ6O6T5 X-Message-ID-Hash: BNYXXZTY5UZQ2WEE2755ERBN2EZ6O6T5 X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-04-24 10:30, Fabian Grünbichler wrote: > On April 24, 2026 12:38 am, Thomas Lamprecht wrote: >> On Wed, 22 Apr 2026 15:39:38 +0200, Hannes Laimer wrote: >>> Add support for moving backup groups and entire namespace subtrees to >>> a different location within the same datastore. >>> >>> Groups are moved with exclusive per-group and per-snapshot locking. >>> For S3, objects are copied to the target prefix before deleting the >>> source. Namespace moves process groups individually, deferring and >>> retrying lock conflicts once, so partially failed moves can be >>> completed with move-group. >>> >>> [...] >> >> Applied, thanks! >> >> Squashed in the relatively trivial fixes for what Michael found, but I really >> could not find any issue with locking after multiple looks, so either that came >> from some side effect in testing or we'd need more info for a good reproducer. > > I can reproduce this easily, and the cause is that the > proxmox-backup-manager CLI handlers directly execute the API endpoints, > instead of going via the proxy.. > > that causes some parent dirs in the locking hiearchy to have the wrong > ownership (755 root:root instead of 755 backup:backup), which then turns > into > > failed to delete snapshot - Error { context: "while destroying snapshot \'BackupDir { store: \"test\", ns: BackupNamespace { inner: [\"foobar\"], len: 7 }, dir: BackupDir { group: BackupGroup { ty: Host, id: \"bookworm\" }, time: 1674040234 }, backup_time_string: \"2023-01-18T11:10:34Z\" }\'", source: Error { context: "unable to acquire snapshot lock \"/run/proxmox-backup/locks/test/foobar/host-bookworm-2023\\\\x2d01\\\\x2d18T11\\\\x3a10\\\\x3a34Z\"", source: "mkstemp \"/run/proxmox-backup/locks/test/foobar/host-bookworm-2023\\\\x2d01\\\\x2d18T11\\\\x3a10\\\\x3a34Z.tmp_XXXXXX\" failed: EACCES: Permission denied", }, } (400) > > because it's not possible for the user backup to create new lock files > in that directory.. cleared by a reboot or recursive chown, and fixed by > either moving those commands to the client, or letting manager connect > to the API. > > it's also a bit weird that > - create namespace > - list namespaces > - delete namespace > > for namespaces are all in proxmox-backup-client, but moving a namespace > is only available in proxmox-backup-manager which lacks all of the > above.. > > similarly, interactions with groups are in the client: > - create snapshot (and thus implictly groups) > - forget snapshots by pruning a group > - forget individual snapshots > - forgetting a whole group > - listing snapshots (and thus groups) > - changing group ownership > > but moving a group is only available in proxmox-backup-manager again, > which has no other group-level commands AFAICT? right, these shouldn't be in the manager. I'll send a fixup moving them! that should also fix the permissions problem, thanks!