From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 899291FF13B for ; Wed, 03 Jun 2026 12:51:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E85F882F0; Wed, 3 Jun 2026 12:51:09 +0200 (CEST) Message-ID: <766abd6e-5cbd-4c04-9fd0-5e8ec9482371@proxmox.com> Date: Wed, 3 Jun 2026 12:50:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox 5/5] pbs-api-types: add GarbageCollection maintenance mode To: Robert Obkircher , pbs-devel@lists.proxmox.com References: <20260602130001.217482-1-r.obkircher@proxmox.com> <20260602130001.217482-6-r.obkircher@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260602130001.217482-6-r.obkircher@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780483798915 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 75UTYFP5ESRTEURZOH2AMVXX5RZOKYRZ X-Message-ID-Hash: 75UTYFP5ESRTEURZOH2AMVXX5RZOKYRZ X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 6/2/26 3:00 PM, Robert Obkircher wrote: > This mode may be used to safely prune and garbage collect a datastore > without the risk of running out of space due to new backups. > > Signed-off-by: Robert Obkircher Reviewed-by: Christian Ebner > --- > pbs-api-types/src/datastore.rs | 1 + > pbs-api-types/src/maintenance.rs | 11 +++++++---- > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs > index b770bc03..f54af000 100644 > --- a/pbs-api-types/src/datastore.rs > +++ b/pbs-api-types/src/datastore.rs > @@ -649,6 +649,7 @@ impl DataStoreConfig { > > match current_type { > Some(MaintenanceType::ReadOnly) => { /* always OK */ } > + Some(MaintenanceType::GarbageCollection) => { /* always OK */ } > Some(MaintenanceType::Offline) => { /* always OK */ } > Some(MaintenanceType::Unmount) => { > /* used to reset it after failed unmount, or alternative for aborting unmount task */ > diff --git a/pbs-api-types/src/maintenance.rs b/pbs-api-types/src/maintenance.rs > index 2d11aff2..abbdbf3f 100644 > --- a/pbs-api-types/src/maintenance.rs > +++ b/pbs-api-types/src/maintenance.rs > @@ -42,12 +42,11 @@ pub enum Operation { > #[serde(rename_all = "kebab-case")] > /// Maintenance type. > pub enum MaintenanceType { > - // TODO: > - // - Add "GarbageCollection" or "DeleteOnly" as type and track GC (or all deletes) as separate > - // operation, so that one can enable a mode where nothing new can be added but stuff can be > - // cleaned > /// Only read operations are allowed on the datastore. > ReadOnly, > + /// Allow reads and non-expanding writes, but disallow writes > + /// that may increase storage usage. > + GarbageCollection, > /// Neither read nor write operations are allowed on the datastore. > Offline, > /// The datastore is being deleted. > @@ -110,6 +109,10 @@ impl MaintenanceMode { > (MaintenanceType::ReadOnly, Operation::Write | Operation::WriteNonExpanding) => { > bail!("read-only maintenance mode: {message}") > } > + (MaintenanceType::GarbageCollection, Operation::Write) => { > + bail!("garbage-collection maintenance mode: {message}") > + } > + (MaintenanceType::GarbageCollection, _) => Ok(()), > #[cfg(feature = "enum-fallback")] > (MaintenanceType::UnknownEnumValue(m), _) => bail!("unknown maintenance mode: {m}"), > }