From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dietmar@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 99202620C0
 for <pbs-devel@lists.proxmox.com>; Mon, 23 Nov 2020 08:08:28 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 831A723DCD
 for <pbs-devel@lists.proxmox.com>; Mon, 23 Nov 2020 08:07:58 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 6A31823DBE
 for <pbs-devel@lists.proxmox.com>; Mon, 23 Nov 2020 08:07:57 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 37B7E43ED2
 for <pbs-devel@lists.proxmox.com>; Mon, 23 Nov 2020 08:07:57 +0100 (CET)
Date: Mon, 23 Nov 2020 08:07:47 +0100 (CET)
From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, 
 =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
Message-ID: <766783011.72.1606115268068@webmail.proxmox.com>
In-Reply-To: <20201120163845.1225080-10-f.gruenbichler@proxmox.com>
References: <20201120163845.1225080-1-f.gruenbichler@proxmox.com>
 <20201120163845.1225080-10-f.gruenbichler@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.4-Rev13
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.116 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup 09/13] paperkey: add short
 key ID to subject
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 23 Nov 2020 07:08:28 -0000


> +            Ok(mut key_config) => {
> +                // add display version of fingerprint to subject and strip from key data
> +                let subject = match (subject, key_config.fingerprint.take()) {
> +                    (Some(mut subject), Some(fingerprint)) => {
> +                        subject.push_str(&format!(" ({})", fingerprint));
> +                        Some(subject)
> +                    },
> +                    (None, Some(fingerprint)) => Some(format!("Fingerprint: {}", fingerprint)),
> +                    (subject, _) => subject,
> +                };
> +

I still don't get why we need a 32byte fingerprint - this is the same length as the key itself!

I want to avoid having keys with different content (strip fingerprint), because this only
confuse people.