From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D071869605 for ; Wed, 24 Feb 2021 08:28:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C391525868 for ; Wed, 24 Feb 2021 08:28:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8EB0625858 for ; Wed, 24 Feb 2021 08:28:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5C9E143738 for ; Wed, 24 Feb 2021 08:28:56 +0100 (CET) Date: Wed, 24 Feb 2021 08:28:54 +0100 (CET) From: Dietmar Maurer To: Proxmox Backup Server development discussion , Thomas Lamprecht , Wolfgang Bumiller Message-ID: <747410998.16.1614151735303@webmail.proxmox.com> In-Reply-To: <654681787.11.1614147199226@webmail.proxmox.com> References: <20210223145403.2126-1-d.csapak@proxmox.com> <1716330912.3668.1614097567040@webmail.proxmox.com> <16b17f26-ec37-fd9f-004d-2fd146a4d900@proxmox.com> <1644937938.10.1614108472151@webmail.proxmox.com> <654681787.11.1614147199226@webmail.proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.4-Rev18 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.116 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup] api2/config/tape_backup_job: fix duplicate id parameter X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2021 07:28:57 -0000 Seems there is another problem with the Updater: I can delete properties if I use normal rust naming, e.g. job.update_from(update, "eject_media")?; But it does not work with kebab-case: job.update_from(update, "eject-media")?; // this fails silently Please can we: - support kebab-case - raise error with unknown property names > On 02/24/2021 7:13 AM Dietmar Maurer wrote: > > > > On 02/23/2021 8:27 PM Dietmar Maurer wrote: > > > > > > Will fix this tomorrow - we need to set the #[fixed] attribute for id > > Just saw that we already set the #[updater(fixed)] attribute. > > The docs say: > > > Additionally the #[updater(fixed)] option is available to make it illegal > > for an updater to modify a field (generating an error if it is set), > > while still allowing it to be used to create a new object via the build_from() method. > > So the Updater includes all "fixed" fields (which leads to the duplicate id problem). > > I would prefer an Updater which simply omits fixed fields. > > Can we change that?