From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 50E1671533 for ; Thu, 8 Apr 2021 10:07:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3C79717DBC for ; Thu, 8 Apr 2021 10:07:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3ED9F17DAC for ; Thu, 8 Apr 2021 10:07:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0A7BF41F51 for ; Thu, 8 Apr 2021 10:07:27 +0200 (CEST) Date: Thu, 8 Apr 2021 10:07:17 +0200 (CEST) From: Dietmar Maurer To: Proxmox Backup Server development discussion , Dominik Csapak Message-ID: <740035669.1343.1617869237658@webmail.proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.5-Rev5 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.113 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, email.rs] Subject: Re: [pbs-devel] [PATCH proxmox] fix #3302: allow more characters for email X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Apr 2021 08:07:59 -0000 Please can we define a pub const regex, so that we can use it in the API? > On 04/08/2021 8:01 AM Dominik Csapak wrote: > > > any comment? we should really allow at least > '_' and '+' in addition > > On 2/12/21 9:40 AM, Dominik Csapak wrote: > > change to something similar as in pve-common > > word characters, +, -, ~ and . for the local part > > > > Signed-off-by: Dominik Csapak > > --- > > proxmox/src/tools/email.rs | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/proxmox/src/tools/email.rs b/proxmox/src/tools/email.rs > > index b5d42c4..c6336f4 100644 > > --- a/proxmox/src/tools/email.rs > > +++ b/proxmox/src/tools/email.rs > > @@ -16,7 +16,7 @@ pub fn sendmail( > > mailfrom: Option<&str>, > > author: Option<&str>, > > ) -> Result<(), Error> { > > - let mail_regex = regex::Regex::new(r"^[a-zA-Z\.0-9-]+@[a-zA-Z\.0-9-]+$").unwrap(); > > + let mail_regex = regex::Regex::new(r"^[\w\+\-\~\.]+@[a-zA-Z\.0-9-]+$").unwrap(); > > > > if mailto.is_empty() { > > bail!("At least one recipient has to be specified!") > > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel