From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BF0CF62CC4 for ; Tue, 14 Jul 2020 11:04:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BCF6324A99 for ; Tue, 14 Jul 2020 11:04:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3FFFB24A8B for ; Tue, 14 Jul 2020 11:04:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0381E42623 for ; Tue, 14 Jul 2020 11:04:47 +0200 (CEST) To: Proxmox Backup Server development discussion , Stefan Reiter References: <20200714084516.6321-1-s.reiter@proxmox.com> From: Thomas Lamprecht Message-ID: <73286077-898e-8d55-2d76-4e30a7a68a62@proxmox.com> Date: Tue, 14 Jul 2020 11:04:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.0 MIME-Version: 1.0 In-Reply-To: <20200714084516.6321-1-s.reiter@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH qemu] Fix dirty-bitmap PBS backup with multiple drives X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2020 09:04:47 -0000 On 14.07.20 10:45, Stefan Reiter wrote: > "PVE backup: rename incremental to use-dirty-bitmap" merged two > variables (use_dirty_bitmap and incremental) into one, but they served > two different purposes. Rename the original use_dirty_bitmap to > "expect_only_dirty" so the new one doesn't conflict, and rework "PVE: > use proxmox_backup_check_incremental" around that semantic. > > In practice, this had the effect that only one disk at a time would > have a bitmap added, as after the first "use_dirty_bitmap" would be set > to one and the rest would behave as if the QMP parameter of the same > name was unset. > > Signed-off-by: Stefan Reiter > --- > > I changed it in the original patches to avoid a fixup on top of fixups, hope > that's good. > > ...name-incremental-to-use-dirty-bitmap.patch | 27 ++++++++-------- > ...irty-counter-for-non-incremental-bac.patch | 6 ++-- > ...use-proxmox_backup_check_incremental.patch | 31 ++++++++----------- > 3 files changed, 30 insertions(+), 34 deletions(-) > > applied, thanks!