From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B45A4695DC for ; Thu, 11 Mar 2021 09:58:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AB37F252BB for ; Thu, 11 Mar 2021 09:58:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 49B6B252AE for ; Thu, 11 Mar 2021 09:58:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 157F8458EB for ; Thu, 11 Mar 2021 09:58:40 +0100 (CET) Message-ID: <70ccd9b1-a6da-40cf-0b4d-0e590983dc4e@proxmox.com> Date: Thu, 11 Mar 2021 09:58:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:87.0) Gecko/20100101 Thunderbird/87.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Dominik Csapak References: <20210311082453.17920-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210311082453.17920-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.049 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH proxmox-backup v2 1/2] tape/send_load_media_email: move to server/email_notifications X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2021 08:58:40 -0000 On 11.03.21 09:24, Dominik Csapak wrote: > and reuse 'send_job_status_mail' there so that we get consistent > formatted mails from pbs (e.g. html part and author) > > Signed-off-by: Dominik Csapak > --- > changes from v1: > * better commit subject/message > * move code to email related module > * do not make send_job_status_mail pub > > src/server/email_notifications.rs | 24 +++++++++++++++++++++ > src/tape/changer/email.rs | 36 ------------------------------- > src/tape/changer/mod.rs | 3 --- > src/tape/drive/mod.rs | 6 ++++-- > 4 files changed, 28 insertions(+), 41 deletions(-) > delete mode 100644 src/tape/changer/email.rs > > applied, thanks!