From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 884101FF380 for ; Fri, 19 Apr 2024 11:54:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4C7375515; Fri, 19 Apr 2024 11:54:20 +0200 (CEST) Message-ID: <705141c5-8931-4e84-ad63-056c0a68225d@proxmox.com> Date: Fri, 19 Apr 2024 11:54:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Hannes Laimer References: <20240419085834.32850-1-h.laimer@proxmox.com> <20240419085834.32850-2-h.laimer@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20240419085834.32850-2-h.laimer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v7 01/20] tools: add disks utility functions X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" nit inline On 4/19/24 10:58, Hannes Laimer wrote: > ... for mounting and unmounting > > Signed-off-by: Hannes Laimer > --- > src/tools/disks/mod.rs | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/src/tools/disks/mod.rs b/src/tools/disks/mod.rs > index 94f89e0a..68854918 100644 > --- a/src/tools/disks/mod.rs > +++ b/src/tools/disks/mod.rs > @@ -1323,3 +1323,22 @@ pub fn get_fs_uuid(disk: &Disk) -> Result { > > bail!("get_fs_uuid failed - missing UUID"); > } > + > +/// Mount a disk by its UUID and the mount point. > +pub fn mount_by_uuid(uuid: &str, mount_point: &Path) -> Result<(), Error> { > + let mut command = std::process::Command::new("mount"); > + command.args([&format!("UUID={uuid}")]); this should be: `command.arg(&format!("UUID={uuid}"));`, or pass already both arguments when using args. > + command.arg(mount_point); > + > + proxmox_sys::command::run_command(command, None)?; > + Ok(()) > +} > + > +/// Unmount a disk by its mount point. > +pub fn unmount_by_mountpoint(path: &str) -> Result<(), Error> { > + let mut command = std::process::Command::new("umount"); > + command.arg(path); > + > + proxmox_sys::command::run_command(command, None)?; > + Ok(()) > +} _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel