From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ronja.mits.lan by ronja.mits.lan with LMTP id aFz5NwKncmZAKAAAxxbTJA (envelope-from ); Wed, 19 Jun 2024 11:38:10 +0200 Received: from proxmox-new.maurer-it.com (unknown [192.168.2.33]) by ronja.mits.lan (Postfix) with ESMTPS id CA34AF63D90; Wed, 19 Jun 2024 11:38:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AE7D047C89; Wed, 19 Jun 2024 11:38:10 +0200 (CEST) Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by proxmox-new.maurer-it.com (Proxmox) with ESMTPS; Wed, 19 Jun 2024 11:38:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0908FC74; Wed, 19 Jun 2024 11:38:09 +0200 (CEST) Date: Wed, 19 Jun 2024 11:37:35 +0200 From: Wolfgang Bumiller To: Gabriel Goller Message-ID: <6l7eyhxgxj2gwpxkbk3rk6axraqyn3arara3ldxcamv33jm3uy@uhtnpakc2xyt> References: <20240603084316.64361-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240603084316.64361-1-g.goller@proxmox.com> Subject: [pbs-devel] applied-series: [PATCH proxmox{, -backup} v7 0/2] close #4763: client: add command to forget backup group X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: pbs-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods MAILING_LIST_MULTI -2 Multiple indicators imply a widely-seen list manager RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record T_SCC_BODY_TEXT_LINE -0.01 - applied this but replaced the `extract_repository_from_value` call with a newly added `remove_repository_from_value` call since this code actually passed the `--repository` parameter on to the remote side, which does not accept unknown parameters anymore On Mon, Jun 03, 2024 at 10:43:09AM GMT, Gabriel Goller wrote: > Add the command `proxmox-backup-client group forget ` so > that we can forget (delete) whole groups with all the containing > snapshots. As this is quite dangerous, we added a prompt, so the > user has to confirm the operation. > > v7, thanks @Wolfgang: > - style nit: return unit type on success in api fn > - let `Confirmation` impl Clone, Copy, and Eq as well > - with Copy we can let the fn's consume self > - organize imports > > v6, thanks @Thomas: > - add more generic confirmation helper drawn up by @Thomas > - stricter yes/no matching with default > > v5, thanks @Christian: > - stricter input matching ($ in regex) > - avoid printing full datastore path > > v4: > - removed localization > > --version 3 has been skipped-- > > v2: > - added localization > > proxmox: > > Gabriel Goller (1): > router: cli: add confirmation helper > > proxmox-router/Cargo.toml | 1 + > proxmox-router/src/cli/mod.rs | 114 +++++++++++++++++++++++++++++++++- > 2 files changed, 114 insertions(+), 1 deletion(-) > > > proxmox-backup: > > Gabriel Goller (1): > close #4763: client: add command to forget backup group > > proxmox-backup-client/src/group.rs | 88 ++++++++++++++++++++++++++++++ > proxmox-backup-client/src/main.rs | 3 + > 2 files changed, 91 insertions(+) > create mode 100644 proxmox-backup-client/src/group.rs > > > Summary over all repositories: > 4 files changed, 205 insertions(+), 1 deletions(-) > > -- > Generated by git-murpp 0.5.0 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel