From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 34D7AB7AC for ; Thu, 7 Apr 2022 11:42:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 219FF2FEC for ; Thu, 7 Apr 2022 11:42:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 836D12FDF for ; Thu, 7 Apr 2022 11:42:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3A1D1459FD for ; Thu, 7 Apr 2022 11:42:46 +0200 (CEST) Message-ID: <6e8a84d9-fbf4-0308-ee3a-7623675bd9d9@proxmox.com> Date: Thu, 7 Apr 2022 11:42:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: Thomas Lamprecht , Proxmox Backup Server development discussion References: <20220324114930.99788-1-m.frank@proxmox.com> <99daec45-2218-1b05-ee75-bc0ce01ceabe@proxmox.com> From: Markus Frank In-Reply-To: <99daec45-2218-1b05-ee75-bc0ce01ceabe@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.416 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.873 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [drive.rs] Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup v7] fix #3854 paperkey import to proxmox-tape X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2022 09:42:47 -0000 Thanks, nothing is missing and everything should work similar to before. Commands I tested (valid): proxmox-tape key restore --key '{...}' proxmox-tape key restore --key-file paperkey.json proxmox-tape key restore --key-file paperkey.backup # with markers proxmox-tape key restore --drive drive1 Error: proxmox-tape key restore --key-file paperkey.json --key '{"kdf": {...' proxmox-tape key restore --drive drive1 --key '{"kdf": {...' proxmox-tape key restore --drive drive1 --key-file test123 proxmox-tape key restore --drive drive1 --key-file test123 \ --key '{"kdf": {...' On 4/6/22 16:35, Thomas Lamprecht wrote: > On 24.03.22 12:49, Markus Frank wrote: >> added a parameter to the cli for importing tape key via a json-parameter or >> via reading a exported paperkey-file or json-file. >> For this i also added a backupkey parameter to the api, but here it only >> accepts json. >> >> The cli interprets the parameter first as json-string, then json-file >> and last as paperkey-file. >> >> functionality: >> proxmox-tape key paperkey [fingerprint of existing key] > paperkey.backup >> proxmox-tape key restore --backupkey paperkey.backup # key from line above >> proxmox-tape key restore --backupkey paperkey.json # only the json >> proxmox-tape key restore --backupkey '{"kdf": {"Scrypt": ...' # json as string >> >> for importing the key as paperkey-file it is irrelevant, if the paperkey got exported as html >> or txt. >> >> Signed-off-by: Markus Frank >> --- > >> src/api2/tape/drive.rs | 65 +++++++++++++++++++------- >> src/bin/proxmox_tape/encryption_key.rs | 59 +++++++++++++++++++++-- >> 2 files changed, 102 insertions(+), 22 deletions(-) >> >> > > applied, thanks! While this was OK code-wise I made a not so small followup commit > for some semantic changes, mostly it was for splitting CLI behavior for key-string > vs. key-file again. Would appreciate if you also re-take a look to ensure I did > not botched something in progress.