From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3816B61BCC for ; Thu, 22 Oct 2020 12:34:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2A96A1F3AC for ; Thu, 22 Oct 2020 12:34:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id AF9D71F3A2 for ; Thu, 22 Oct 2020 12:34:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 74CCC45E8F for ; Thu, 22 Oct 2020 12:34:43 +0200 (CEST) To: Proxmox Backup Server development discussion , =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20201005145703.26529-1-t.lamprecht@proxmox.com> <3c7181e5-9e21-9071-cfd5-dd97884e024e@proxmox.com> <1603354658.wifegpzioo.astroid@nora.none> From: Thomas Lamprecht Message-ID: <6c818c31-58c2-afaf-f6a0-7d2404e1fc57@proxmox.com> Date: Thu, 22 Oct 2020 12:34:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: <1603354658.wifegpzioo.astroid@nora.none> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.125 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [api2.rs] Subject: Re: [pbs-devel] [PATCH backup] api: add world accessible ping dummy endpoint X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Oct 2020 10:34:44 -0000 On 22.10.20 10:18, Fabian Gr=C3=BCnbichler wrote: > On October 21, 2020 8:32 pm, Thomas Lamprecht wrote: >> On 05.10.20 16:57, Thomas Lamprecht wrote: >>> This is indented to be used for the PVE storage library, replacing >>> the missuse of the much more expensive status API call. >>> >>> Signed-off-by: Thomas Lamprecht >>> --- >>> >>> I initially thought about adding this to the proxmox-backup-client as= command, >>> but it's not much of use there (user can just use the version command= ) and for >>> the PVE integration we can do a simple http request with LWP, which i= s much >>> cheaper than fork+exec the client there. >>> >> >> any objections to this? Else I'd apply it as is.. >=20 > LGTM, maybe besides that having a separate file for this instead of jus= t=20 > inlining it into api2.rs seems overkill :-P >=20 Thought so first too, but it made the top level API entry point quite a b= it uglier, more noisier, and as the separate file does not costs much I went for tha= t way :)